Skip to content

Only calculate checksums, when there are files to monitor.#2776

Merged
casperklein merged 4 commits intodocker-mailserver:masterfrom
casperklein:fix-2775
Sep 19, 2022
Merged

Only calculate checksums, when there are files to monitor.#2776
casperklein merged 4 commits intodocker-mailserver:masterfrom
casperklein:fix-2775

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Sep 18, 2022 •
edited
Loading

Description

This PR fixes a bug, where checksum calculation was done/tried, when there were no files to monitor.

Fixes #2775

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein self-assigned this Sep 18, 2022
@casperklein casperklein added this to the v11.2.0 milestone Sep 18, 2022
@casperklein casperklein changed the title Only calculate checksum, when there are files to monitor. Only calculate checksums, when there are files to monitor. Sep 18, 2022
@casperklein casperklein requested a review from a team September 18, 2022 11:24
@casperklein casperklein marked this pull request as ready for review September 18, 2022 11:25
georglauterbach
georglauterbach reviewed Sep 18, 2022
View reviewed changes
Comment thread target/scripts/helpers/change-detection.sh Outdated
@casperklein casperklein marked this pull request as draft September 18, 2022 16:04
@casperklein casperklein marked this pull request as ready for review September 18, 2022 16:12
@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Sep 18, 2022 •
edited
Loading

set -u complains about CHANGED_FILES not being set even though it was declared earlier? That is weird.. I will double check this, as the failing test seems unrelated to me.

@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented Sep 18, 2022

See here:

set -u
declare -a foo
echo $foo
-bash: foo: unbound variable

However, I am not sure anymore if there is even 'set -u' in place, that caused the failing tests. That may be a wrong assumption from me earlier.

f72bc78 fixed it. But I don't know exactly why 🤷

georglauterbach
georglauterbach approved these changes Sep 19, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing with the array and ´set -u` is pretty weird .. :D

@casperklein casperklein merged commit 1f137f3 into docker-mailserver:master Sep 19, 2022
@casperklein casperklein deleted the fix-2775 branch September 19, 2022 08:45
@casperklein casperklein mentioned this pull request Sep 27, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels

area/scripts area/tests

Projects

None yet

Milestone

v11.2.0

Development

Successfully merging this pull request may close these issues.

[BUG] DMS fails to start, when SMTP_ONLY=1 is used and no user is present.

3 participants

@casperklein @georglauterbach @polarathene