Skip to content

Remove unnecessary postconf switch '-e' and use single quotes where possible#2746

Merged
casperklein merged 2 commits intodocker-mailserver:masterfrom
casperklein:postconf
Aug 29, 2022
Merged

Remove unnecessary postconf switch '-e' and use single quotes where possible#2746
casperklein merged 2 commits intodocker-mailserver:masterfrom
casperklein:postconf

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Aug 28, 2022

Description

This PR streamlines the postconf usage to not use the -e option, as it's the default since Postfix version >=2.8

From the man page: The -e option is no longer needed with Postfix version 2.8 and later.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein self-assigned this Aug 28, 2022
@casperklein casperklein added service/postfix area/scripts area/tests kind/improvement Improve an existing feature, configuration file or the documentation labels Aug 28, 2022
@casperklein casperklein added this to the v11.2.0 milestone Aug 28, 2022
@casperklein casperklein marked this pull request as ready for review August 28, 2022 21:37
@casperklein casperklein requested a review from a team August 28, 2022 21:37
@casperklein casperklein merged commit efed7d9 into docker-mailserver:master Aug 29, 2022
@casperklein casperklein deleted the postconf branch August 29, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/scripts area/tests kind/improvement Improve an existing feature, configuration file or the documentation service/postfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants