Skip to content

scripts: revised linting script#2737

Merged
georglauterbach merged 3 commits intomasterfrom
ci/linting
Aug 22, 2022
Merged

scripts: revised linting script#2737
georglauterbach merged 3 commits intomasterfrom
ci/linting

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

Description

The new version uses our log.sh helper to simplify logging
significantly. Moreover, the script was adjusted to the current style
and the GitHub workflow was streamlined. The workflow is ot providing
the version anymore (which was useless anyway), and has been compacted.

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

The new version uses our `log.sh` helper to simplify logging
significantly. Moreover, the script was adjusted to the current style
and the GitHub workflow was streamlined. The workflow is ot providing
the version anymore (which was useless anyway), and has been compacted.
@georglauterbach georglauterbach added area/ci area/scripts kind/update Update an existing feature, configuration file or the documentation labels Aug 21, 2022
@georglauterbach georglauterbach added this to the v11.2.0 milestone Aug 21, 2022
@georglauterbach georglauterbach self-assigned this Aug 21, 2022
polarathene
polarathene previously approved these changes Aug 21, 2022
Copy link
Copy Markdown
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Great work! 😀

Comment thread .github/workflows/linting.yml Outdated
I noticed that `branches: [ '**' ]` is a pretty useless restriction,
because it basically says "run on all branches". As a consequence, I
dropped the restriction.
@georglauterbach georglauterbach merged commit 8a4329a into master Aug 22, 2022
@georglauterbach georglauterbach deleted the ci/linting branch August 22, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci area/scripts kind/update Update an existing feature, configuration file or the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants