fix: _create_accounts() should run after waiting#2731
Merged
polarathene merged 1 commit intomasterfrom Aug 21, 2022
Merged
Conversation
When waiting on an account to be added to `postfix-accounts.cf`, Dovecot account creation at startup was already run. Startup continued without properly creating the account for Dovecot. Methods like `setup email list` (with `ENABLE_QUOTAS=1`) would fail. Requiring the `changedetector` service to be triggered to re-create Dovecot users. - Wrapped the logic for wait + shutdown into a function call. - Moved `_create_accounts()` to bottom of the setup function.
casperklein
approved these changes
Aug 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When waiting on an account to be added to
postfix-accounts.cf, Dovecot account creation during the startup process had already run.Startup continued without properly creating the mail account for Dovecot. Methods like
setup email list(withENABLE_QUOTAS=1) would fail.changedetectorservice was required to be triggered to re-create Dovecot users._create_accounts()to bottom of the setup function.Type of change
Checklist: