docs: Improve cron tasks and fix link in documentation#2708
Merged
polarathene merged 6 commits intodocker-mailserver:masterfrom Aug 2, 2022
JiLleON:improve-documentation
Merged
docs: Improve cron tasks and fix link in documentation#2708polarathene merged 6 commits intodocker-mailserver:masterfrom JiLleON:improve-documentation
polarathene merged 6 commits intodocker-mailserver:masterfrom
JiLleON:improve-documentation
Conversation
adding an example with cron inside container to avoid possible errors adding 'MAILTO=""' option to the cron tasks to prevent cron from sending messages to email after completing tasks
georglauterbach
added
kind/improvement
polarathene
requested changes
Jul 31, 2022
Co-authored-by: Brennan Kinney <[email protected]>
polarathene
previously approved these changes
Aug 1, 2022
Member
polarathene
left a comment
polarathene
left a comment
There was a problem hiding this comment.
LGTM 👍
You might want to still confirm the request from @casperklein on the associated issue.
While I don't mind the MAILTO mention since the comment makes it clear what it prevents, some users may prefer to still be notified about failures, while ignoring successful tasks.
adding '> /dev/null' instead of 'MAILTO=""' that only error messages come to the email '[email protected]'
casperklein
previously approved these changes
Aug 1, 2022
polarathene
reviewed
Aug 1, 2022
Contributor
|
Documentation preview for this PR is ready! 🎉 Built with commit: fbab83f |
casperklein
approved these changes
Aug 2, 2022
polarathene
approved these changes
Aug 2, 2022
| # This assumes you're having `environment: ONE_DIR=1` in the env-mailserver, | ||
| # with a consolidated config in `/var/mail-state` | ||
| # | ||
| # '> /dev/null' to send error notifications from 'stderr' to '[email protected]' |
Member
There was a problem hiding this comment.
It's technically meant to omit stdout to avoid reports that are unnecessary, thus only stderr would trigger reports.
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Everything that was mentioned in the issue and fixing the link to the actual
Fixes #2702
Type of change
Checklist:
docs/)