fix(setup.sh): Do not override an existing CONTAINER_NAME value#2622
Merged
polarathene merged 2 commits intodocker-mailserver:masterfrom Jun 6, 2022
Merged
Conversation
This bug was causing `setup.sh -c` to target the wrong container.
4 tasks
casperklein
approved these changes
Jun 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This bug was causing
setup.sh -cto target the wrong container when an earlierdocker-mailservercontainer was already running.I believe this is to try lookup an implicit default, but an explicit value for
-csetsCONTAINER_NAMEprior to this and should be used. It was causing some recent test failures intest/mail_with_relays.bats, both on CI and my local VM.Type of change
Checklist: