fix: Amavis should reload config for /etc/postfix/vhost updates#2616
Merged
polarathene merged 3 commits intodocker-mailserver:masterfrom Jun 15, 2022
Merged
Conversation
polarathene
added
area/security
pr/waiting for other PR to get merged
Amavis was not aware of new domains in vhost as it did not refresh it's sources upon change detection.
polarathene
force-pushed
the
fix/change-detection-amavis
branch
from
25ffbfc to
aa873c7
Compare
polarathene
removed
the
pr/waiting for other PR to get merged
polarathene
commented
Jun 12, 2022
| then | ||
| # /etc/postfix/vhost was updated, amavis must refresh it's config by | ||
| # reading this file again in case of new domains, otherwise they will be ignored. | ||
| amavisd-new reload |
Member
Author
There was a problem hiding this comment.
Presumably supervisorctl restart amavis should be used.
I've not received any feedback about better understanding why postfix reload was an issue in the past (may have been due to the present postfix-wrapper.sh script?).
Member
There was a problem hiding this comment.
Truth be told, I don‘t know 🙈 @casperklein do you have an idea?:)
Member
There was a problem hiding this comment.
The usage of amavisd-new reload should be fine. However, if for some reason a complete service restart is needed, supervisorctl restart amavis should be used.
polarathene
commented
Jun 13, 2022
casperklein
approved these changes
Jun 14, 2022
georglauterbach
approved these changes
Jun 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
/etc/postfix/vhostis updated from change detection, Amavis did not refresh that source, and thus would not be aware of any new domains, ignoring them for spam/virus checking.A test could probably be added, my time is focused on prepping PRs with the time I have available right now.
Type of change
Checklist: