refactor: Migrate SASL_PASSWD ENV support#2605
Merged
polarathene merged 2 commits intodocker-mailserver:masterfrom Jun 5, 2022
Merged
refactor: Migrate SASL_PASSWD ENV support#2605polarathene merged 2 commits intodocker-mailserver:masterfrom
SASL_PASSWD ENV support#2605polarathene merged 2 commits intodocker-mailserver:masterfrom
Conversation
polarathene
added
priority/high
service/postfix
area/scripts
kind/improvement
6 tasks
polarathene
added
the
pr/waiting for other PR to get merged
polarathene
force-pushed
the
refactor/migrate-env-sasl_passwd-support
branch
from
399be26 to
ed262a5
Compare
This helper was to support an earlier ENV for SASL auth support. When extracting logic into individual helpers, it was assumed this was separate from relay support, which it appears was not the case. --- The `SASL_PASSWD` ENV is specified in tests but no longer used. There is no `external-domain.com` relay configured or tested against anywhere in the project. The ENV was likely used in tests prior to improved relay support that allowed for adding more than a single set of relay credentials. --- It likewise has no real relevance anywhere else outside of `relay.sh` as it's the only portion of code to operate with it. It's only relevant for SASL auth as an SMTP client, not the SMTP server (`smtpd`) SASL support that is delegated to Dovecot. Functionality has been completely migrated into `relay.sh` as a result. Documentation is poor for this ENV, it is unlikely in wide use? Should consider for removal. --- The ENV has been dependent upon `RELAY_HOST` to actually enable postfix to use `/etc/postfix/sasl_passwd`, thus not likely relevant in existing setups? --- Migrate `/etc/postfix/sasl_passwd` check from `tests.bats` as it belongs to relay tests.
4 tasks
polarathene
removed
the
pr/waiting for other PR to get merged
polarathene
force-pushed
the
refactor/migrate-env-sasl_passwd-support
branch
from
ed262a5 to
0d38aef
Compare
casperklein
approved these changes
Jun 5, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I would like to merge this for
git blamehistory, but otherwise seeSASL_PASSWDbeing removedshortly afterin next major.See the prior PR this one builds off of for Relay support feature history if additional context is needed. These changes were originally part of the prior PR but seemed more suited for a separate review/discussion.
Changes:
SASL_PASSWDwas an ENV introduced for the initial and very basic relay-host support offered back in 2016./etc/postfix/sasl_passwdconfig).helpers/relay.shwhich is where it belongs.Commit message for reference:
helpers/sasl.shwas to support an earlier ENV for SASL auth support. When extracting logic into individual helpers, it was assumed this was separate from relay support, which it appears was not the case.SASL_PASSWDENV is specified in tests but no longer used. There is noexternal-domain.comrelay configured or tested against anywhere in the project.relay.shas it's the only portion of code to operate with it.smtpd) SASL support that is delegated to Dovecot. Functionality has been completely migrated intorelay.shas a result.RELAY_HOSTto actually enable postfix to use/etc/postfix/sasl_passwd, thus not likely relevant in existing setups?/etc/postfix/sasl_passwdcheck fromtests.batsas it belongs to relay tests.Type of change
Checklist: