scripts: use color variables instead of escape codes#2565
Merged
casperklein merged 6 commits intodocker-mailserver:masterfrom May 10, 2022
Merged
scripts: use color variables instead of escape codes#2565casperklein merged 6 commits intodocker-mailserver:masterfrom
casperklein merged 6 commits intodocker-mailserver:masterfrom
Conversation
casperklein
added
area/scripts
kind/improvement
casperklein
added a commit
to casperklein/archive_docker-mailserver
that referenced
this pull request
Apr 28, 2022
polarathene
approved these changes
May 4, 2022
Member
polarathene
left a comment
polarathene
left a comment
There was a problem hiding this comment.
i think it's clear from the variable name what the usage is
I'm not sure if that applies to ${RESET} though?
Depending on which PR gets merged first, might want to keep #2535 in mind since it's adding a bunch of new setup commands that would need to be converted.
Member
Author
Standing alone, maybe not. But it's only used in context of color usage so I think it's fine. |
Member
Author
|
To not make things harder for #2535, I'll wait with merging this. |
georglauterbach
approved these changes
May 10, 2022
Member
georglauterbach
left a comment
georglauterbach
left a comment
There was a problem hiding this comment.
If we, in the future, realize that we may need the prefix we can always add it :)
georglauterbach
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR streamlines the color usage of the scripts. Color variables are now globally defined in
log.sh. I did not use a separate file likecolors.sh, because some scripts only sourcelog.shType of change
Checklist:
docs/)