Skip to content

chore: (setup-stack.sh) Fix a small typo#2552

Merged
polarathene merged 3 commits intomasterfrom
chore/log-typo-fix
Apr 19, 2022
Merged

chore: (setup-stack.sh) Fix a small typo#2552
polarathene merged 3 commits intomasterfrom
chore/log-typo-fix

Conversation

@polarathene
Copy link
Copy Markdown
Member

Description

Spotted a typo.

@polarathene polarathene self-assigned this Apr 18, 2022
@polarathene polarathene added this to the v11.0.0 milestone Apr 18, 2022
Copy link
Copy Markdown
Member

@casperklein casperklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, this is not strictly a typo: Authentication is the preferred form in English. The variant authentification is acceptable, but less common..

it’s often used by non-native speakers who aren’t aware that it’s less idiomatic in English, because authentification (or an analogue) is the correct form (or at least widely accepted) in many eastern & western European languages

Stupid german contributors I guess 😂 🤘

@polarathene
Copy link
Copy Markdown
Member Author

This has been in the project since the line was introduced in Oct 2016 for adding initial LDAP support 😅

I was aware of the technically valid usage (searched it up myself just in-case 😛 ), but I think it'd be more consistent with usage elsewhere (only 2 other "authentication" mentions in this particular script though) 😄

@polarathene polarathene merged commit 9aaf15b into master Apr 19, 2022
@polarathene polarathene deleted the chore/log-typo-fix branch April 19, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants