Fix changedetector restart loop#2548
Merged
casperklein merged 8 commits intodocker-mailserver:masterfrom Apr 19, 2022
Merged
Conversation
polarathene
approved these changes
Apr 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The supervisord configuration for changedetector always restarts the service once it exits:
docker-mailserver/target/supervisor/conf.d/supervisor-app.conf
Line 76 in 3cb5668
In case the changedetector service exits with an error, it's restarted. This leads to an endless exit and restart loop.
To prevent this,
autorestart=truehas been removed from the configuration. This lets supervisord only restart the service, when it exits with error code >0.The function
_exit_with_errornow allows to pass a second argument: the exit code.In case of an error, changedetector exits as before, but will not be restarted by supervisord.
Fixes #2546
Type of change
Checklist:
docs/)