Skip to content

Dockerfile: Remove not needed ENVs and add comment#2541

Merged
casperklein merged 5 commits intodocker-mailserver:masterfrom
casperklein:dockerfile-env
Apr 18, 2022
Merged

Dockerfile: Remove not needed ENVs and add comment#2541
casperklein merged 5 commits intodocker-mailserver:masterfrom
casperklein:dockerfile-env

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Apr 10, 2022

Description

This PR removes not needed ENVs and adds a comment to clarify, why the other ENVs are needed.

These ENVs are not needed, they are handled by start-mailserver.sh like all other ENVs in DMS:

  • ONE_DIR=1
  • ENABLE_POSTGREY
  • SASLAUTHD_MECHANISMS

The remaining ENVs are referenced in target/supervisor/conf.d/saslauth.conf and must be present when supervisord starts (tested).

If necessary, their values are adjusted by start-mailserver.sh on startup.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein self-assigned this Apr 10, 2022
@casperklein casperklein added the kind/improvement Improve an existing feature, configuration file or the documentation label Apr 10, 2022
@casperklein casperklein marked this pull request as ready for review April 10, 2022 22:07
@casperklein casperklein requested a review from a team April 10, 2022 22:07
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Copy link
Copy Markdown
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx

Comment thread Dockerfile
@georglauterbach georglauterbach added this to the v11.0.0 milestone Apr 18, 2022
@casperklein casperklein merged commit 80dd91a into docker-mailserver:master Apr 18, 2022
@casperklein casperklein deleted the dockerfile-env branch April 18, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants