Skip to content

setup.sh/setup: show usage when no argument is given#2540

Merged
casperklein merged 6 commits intodocker-mailserver:masterfrom
casperklein:setup.sh-show-help
Apr 18, 2022
Merged

setup.sh/setup: show usage when no argument is given#2540
casperklein merged 6 commits intodocker-mailserver:masterfrom
casperklein:setup.sh-show-help

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Apr 9, 2022

Description

When running setup.sh without arguments, this is shown:

The command '' is invalid.
Use `./setup.sh help` to get an overview of all commands.

Then the user typically runs ./setup.sh help to see the available commands. This PR saves a user this additional step, by assuming 'help', when no argument is given.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein added area/scripts kind/improvement Improve an existing feature, configuration file or the documentation labels Apr 9, 2022
@casperklein casperklein added this to the v11.0.0 milestone Apr 9, 2022
@casperklein casperklein requested a review from a team April 9, 2022 22:10
@casperklein casperklein self-assigned this Apr 9, 2022
@casperklein casperklein marked this pull request as draft April 9, 2022 22:58
@casperklein casperklein marked this pull request as ready for review April 9, 2022 23:08
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@casperklein casperklein merged commit ee0c088 into docker-mailserver:master Apr 18, 2022
@casperklein casperklein deleted the setup.sh-show-help branch April 18, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/scripts kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants