Skip to content

tests: enable tests that should pass now for Let'sEncrypt#2524

Closed
georglauterbach wants to merge 1 commit intomasterfrom
tests/enable-more-LE-tests
Closed

tests: enable tests that should pass now for Let'sEncrypt#2524
georglauterbach wants to merge 1 commit intomasterfrom
tests/enable-more-LE-tests

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

Description

Enabled tests that should, according to the comments, pass now.

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach added area/ci kind/update Update an existing feature, configuration file or the documentation labels Apr 2, 2022
@georglauterbach georglauterbach added this to the v11.0.0 milestone Apr 2, 2022
@georglauterbach georglauterbach self-assigned this Apr 2, 2022
@georglauterbach
Copy link
Copy Markdown
Member Author

@polarathene any idea why these tests do not pass? According to the TODO notes they should...

@polarathene

This comment was marked as resolved.

@polarathene
Copy link
Copy Markdown
Member

Option B implemented.

@georglauterbach georglauterbach added pr/waiting for other PR to get merged This PR is waiting for another / other PR(s) to get merged and removed pr/waiting for other PR to get merged This PR is waiting for another / other PR(s) to get merged labels Apr 3, 2022
@georglauterbach
Copy link
Copy Markdown
Member Author

Changes implemented in #2525.

@georglauterbach georglauterbach deleted the tests/enable-more-LE-tests branch April 4, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci kind/update Update an existing feature, configuration file or the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants