Skip to content

Remove invalid URL from SPF message#2503

Merged
casperklein merged 1 commit intodocker-mailserver:masterfrom
casperklein:SPF-Reason-Message
Mar 22, 2022
Merged

Remove invalid URL from SPF message#2503
casperklein merged 1 commit intodocker-mailserver:masterfrom
casperklein:SPF-Reason-Message

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Mar 21, 2022

Description

http://www.openspf.net/ is not available anymore.

This PR removes the URL from the SPF failure messages. The message is handled in policyd-spf.conf.

Default value: Reason_Message = Message {rejectdefer} due to: {spf}. Please see {url}

New value: Reason_Message = Message {rejectdefer} due to: {spf}.

Before:

Mar 4 21:56:01 mail postfix/smtpd[463350]: NOQUEUE: reject: RCPT from unknown[redacted]: 550 5.7.23 <[email protected]>: Recipient address rejected: Message rejected due to: SPF fail - not authorized. Please see http://www.openspf.net/Why?s=mfrom;r=<UNKNOWN>; from=<[email protected]> to=<[email protected]> proto=ESMTP helo=<spammerdomain.org>

After:

Mar 4 21:56:01 mail postfix/smtpd[463350]: NOQUEUE: reject: RCPT from unknown[redacted]: 550 5.7.23 <[email protected]>: Recipient address rejected: Message rejected due to: SPF fail - not authorized.; from=<[email protected]> to=<[email protected]> proto=ESMTP helo=<spammerdomain.org>

Fixes #2459

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein marked this pull request as ready for review March 21, 2022 23:38
@casperklein casperklein requested a review from a team March 22, 2022 00:13
@casperklein casperklein merged commit f22d75f into docker-mailserver:master Mar 22, 2022
@casperklein casperklein deleted the SPF-Reason-Message branch March 22, 2022 16:53
@casperklein casperklein added this to the v11.0.0 milestone Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] SPF fail - openspf.net is no more

4 participants