scripts: renamed function _errex -> _exit_with_error#2497
Merged
georglauterbach merged 2 commits intomasterfrom Mar 21, 2022
Merged
scripts: renamed function _errex -> _exit_with_error#2497georglauterbach merged 2 commits intomasterfrom
_errex -> _exit_with_error#2497georglauterbach merged 2 commits intomasterfrom
Conversation
To maintainers, it is clear what `_errex` is, because we're working with it frequently. The nameing choice, however, was (IMHO) no good. It is needlessly short (why abbreviate error) and does not communicate its functionality very well. Now, it's very clear and yet not too long.
polarathene
approved these changes
Mar 21, 2022
casperklein
approved these changes
Mar 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To maintainers, it is clear what
_errexis, because we're working withit frequently. The nameing choice, however, was (IMHO) no good. It is
needlessly short (why abbreviate error) and does not communicate its
functionality very well.
Now, it's very clear and yet not too long.## Type of change
Checklist:
docs/)