Skip to content

Remove macOS specific code / support + shellcheck should avoid python, regardless of permissions#2466

Merged
NorseGaud merged 6 commits intomasterfrom
revert-macos-logic
Mar 9, 2022
Merged

Remove macOS specific code / support + shellcheck should avoid python, regardless of permissions#2466
NorseGaud merged 6 commits intomasterfrom
revert-macos-logic

Conversation

@NorseGaud
Copy link
Copy Markdown
Member

@NorseGaud NorseGaud commented Mar 6, 2022 •
edited
Loading

Description

Supporting macOS is a nightmare. Users can run a headless linux VM, mount the docker-mailserver directory into it, and run make commands if they are on macOS.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • [ https://github.com/[BUG] Building Dockerfile locally fails #2023 ] New and existing unit tests pass locally with my changes

@NorseGaud NorseGaud force-pushed the revert-macos-logic branch from 61ad30e to 54e41d0 Compare March 6, 2022 17:00
@NorseGaud
Copy link
Copy Markdown
Member Author

NorseGaud commented Mar 6, 2022

I'm sort of stuck running the tests and stuff locally... Per #2467, postfix won't install due to the builder container not having a full FQDN

@NorseGaud
Copy link
Copy Markdown
Member Author

NorseGaud commented Mar 6, 2022 •
edited
Loading

I made two unrelated to the PR, but blocker fix changes in this :

  1. Avoid leaving build container around (they would pile up while testing the build)
  2. Using grep to avoid python script since my virtual machine mount forces all of the target/bin/ files to be executable and fails shellcheck.

@NorseGaud NorseGaud marked this pull request as ready for review March 7, 2022 00:07
@NorseGaud NorseGaud requested a review from a team March 7, 2022 00:07
@NorseGaud NorseGaud self-assigned this Mar 7, 2022
@NorseGaud NorseGaud added area/documentation area/scripts area/tests kind/update Update an existing feature, configuration file or the documentation os/macOS priority/medium labels Mar 7, 2022
casperklein
casperklein reviewed Mar 7, 2022
View reviewed changes
Comment thread test/linting/lint.sh Outdated
polarathene
polarathene previously approved these changes Mar 7, 2022
View reviewed changes
Comment thread Makefile Outdated
@NorseGaud NorseGaud force-pushed the revert-macos-logic branch from 51caaf6 to 1ab8ea9 Compare March 7, 2022 03:17
@NorseGaud NorseGaud changed the title Remove macOS specific code / support Remove macOS specific code / support + shellcheck should avoid python, regardless of permissions Mar 7, 2022
polarathene
polarathene previously approved these changes Mar 7, 2022
View reviewed changes
casperklein
casperklein requested changes Mar 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@casperklein casperklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But there are still some ${@:+$@} left in setup.sh and lint.sh

@NorseGaud NorseGaud force-pushed the revert-macos-logic branch from 4d615e2 to 66cf4f3 Compare March 8, 2022 23:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 9, 2022

Documentation preview for this PR is ready! 🎉

Built with commit: 45068ff

georglauterbach
georglauterbach approved these changes Mar 9, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently on vacation in Madeira, therefore only had a quick look, but LGTM

@NorseGaud NorseGaud merged commit 67533d7 into master Mar 9, 2022
@NorseGaud NorseGaud deleted the revert-macos-logic branch March 9, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@NorseGaud NorseGaud

Labels

area/documentation area/scripts area/tests kind/update Update an existing feature, configuration file or the documentation os/macOS priority/medium

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NorseGaud @casperklein @polarathene @georglauterbach