Skip to content

fix: remove SA reload for KAM#2456

Merged
casperklein merged 4 commits intomasterfrom
fix/error_message_sa_kam
Mar 4, 2022
Merged

fix: remove SA reload for KAM#2456
casperklein merged 4 commits intomasterfrom
fix/error_message_sa_kam

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Mar 3, 2022

Description

Reading #2412 (comment) I should have intervened when the SA reload line was added. The comments
says:

Note: SpamAssassin runs under Amavis  (so there isn't a "spamd" process)
/etc/spamassassin/sa-update-hooks.d/amavisd-new   takes care of reloading SpamAssassin after rules are updated
So, there is no point running "/etc/init.d/spamassassin reload", because it will fail   ("/etc/cron.daily/spamassassin" runs this command, but fails)

Fixes an error reported by cron that the update failed (which is expected...)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach
remove SA reload
bf68812 
Reading #2412 (comment)
I should have intervened when the SA reload line was added. The comments
says:

``` QUOTE
Note: SpamAssassin runs under Amavis  (so there isn't a "spamd" process)
/etc/spamassassin/sa-update-hooks.d/amavisd-new   takes care of reloading SpamAssassin after rules are updated
So, there is no point running "/etc/init.d/spamassassin reload", because it will fail   ("/etc/cron.daily/spamassassin" runs this command, but fails)
```
@georglauterbach georglauterbach added this to the v11.0.0 milestone Mar 3, 2022
@georglauterbach georglauterbach requested a review from a team March 3, 2022 10:34
@georglauterbach georglauterbach self-assigned this Mar 3, 2022
casperklein
casperklein previously approved these changes Mar 3, 2022
View reviewed changes
polarathene
polarathene requested changes Mar 3, 2022
View reviewed changes
Comment thread target/scripts/startup/setup-stack.sh Outdated
@georglauterbach georglauterbach mentioned this pull request Mar 3, 2022
Closed
7 tasks
@georglauterbach georglauterbach linked an issue Mar 3, 2022 that may be closed by this pull request
[BUG] Daily cronjob of Spamassassin KAM is failing #2458
Closed
7 tasks
@casperklein casperklein merged commit d101d0a into master Mar 4, 2022
@casperklein casperklein deleted the fix/error_message_sa_kam branch March 4, 2022 22:38
@casperklein casperklein mentioned this pull request Mar 4, 2022
Closed
11 tasks
@ghnp5
Copy link
Copy Markdown
Contributor

ghnp5 commented Mar 6, 2022 •
edited
Loading

Ah... I was going to report this :)

/etc/cron.daily/spamassassin_KAM:
Update available for channel kam.sa-channels.mcgrail.com: 1646438287 -> 1646497491
http: (curl) GET http://sa-update-kam.snb.it/1646497491.tar.gz, success
http: (curl) GET http://sa-update-kam.snb.it/1646497491.tar.gz.sha512, success
Update was available, and was downloaded and installed successfully
run-parts: /etc/cron.daily/spamassassin_kam exited with return code 1

SpamAssassin runs under Amavis, so "reload" doesn't work.

/etc/cron.daily/spamassassin runs "reload", but the script itself doesn't seem to report as returning exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

@polarathene polarathene polarathene approved these changes

Assignees

@georglauterbach georglauterbach

Labels

area/scripts priority/medium

Projects

None yet

Milestone

v11.0.0

Development

Successfully merging this pull request may close these issues.

[BUG] Daily cronjob of Spamassassin KAM is failing

4 participants

@georglauterbach @ghnp5 @casperklein @polarathene