Skip to content

setup.sh: Remove obsolete 'debug inspect' command from usage text#2454

Merged
casperklein merged 3 commits intodocker-mailserver:masterfrom
casperklein:fix-debug-inspect
Mar 3, 2022
Merged

setup.sh: Remove obsolete 'debug inspect' command from usage text#2454
casperklein merged 3 commits intodocker-mailserver:masterfrom
casperklein:fix-debug-inspect

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Mar 3, 2022 •
edited
Loading

Description

Fixes #2451

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein self-assigned this Mar 3, 2022
@casperklein casperklein added this to the v11.0.0 milestone Mar 3, 2022
@casperklein casperklein marked this pull request as ready for review March 3, 2022 00:45
@casperklein casperklein requested a review from a team March 3, 2022 00:45
@casperklein casperklein enabled auto-merge (squash) March 3, 2022 11:38
@casperklein casperklein merged commit 1911f9a into docker-mailserver:master Mar 3, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2022

Documentation preview for this PR is ready! 🎉

Built with commit: bad5dcb

@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented Mar 3, 2022

Interesting, auto-merge doesn't wait for running checks to complete.

@casperklein casperklein deleted the fix-debug-inspect branch March 3, 2022 11:40
@wernerfred
Copy link
Copy Markdown
Member

wernerfred commented Mar 4, 2022

Interesting, auto-merge doesn't wait for running checks to complete.

We had this "Issue" discussed in the past already. In the protected branch/repo settings we have configured that CI/CD must run in order to allow merging. In this setting you have to choose which workflow has to run and we can only choose the linting one. Otherwise MRs that only have changes to e.g. markdown files will be blocked as the build workflow is listed as requiered but will never run as it is not triggered by changes to only markdown files.

The other way this means when hitting "merge if pipeline succeeds" it will only wait for the required ones to pass.

I already tried to workaround this behavior (maybe it has changed lately - need to doublecheck) but it always ended in running the whole test suite for every change (which we voted against when discussion the introduction of github actions after the migration).

@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented Mar 4, 2022

Thanks for the refresher 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels

area/scripts

Projects

None yet

Milestone

v11.0.0

Development

Successfully merging this pull request may close these issues.

[BUG] The command 'debug inspect' is invalid

4 participants

@casperklein @wernerfred @polarathene @georglauterbach