Skip to content

Introduce CLAMAV_MESSAGE_SIZE_LIMIT env#2453

Merged
casperklein merged 8 commits intodocker-mailserver:masterfrom
casperklein:fix-2450
Mar 3, 2022
Merged

Introduce CLAMAV_MESSAGE_SIZE_LIMIT env#2453
casperklein merged 8 commits intodocker-mailserver:masterfrom
casperklein:fix-2450

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Mar 2, 2022 •
edited
Loading

Description

Mails larger than $CLAMAV_MESSAGE_SIZE_LIMIT won't be scanned.

Fixes #2450

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein added kind/new feature A new feature is requested in this issue or implemeted with this PR area/scripts labels Mar 2, 2022
@casperklein casperklein added this to the v11.0.0 milestone Mar 2, 2022
@casperklein casperklein self-assigned this Mar 2, 2022
@casperklein casperklein marked this pull request as ready for review March 2, 2022 23:48
@casperklein casperklein requested a review from a team March 2, 2022 23:48
@casperklein casperklein marked this pull request as draft March 3, 2022 00:03
@casperklein casperklein marked this pull request as ready for review March 3, 2022 00:26
georglauterbach
georglauterbach previously approved these changes Mar 3, 2022
View reviewed changes
polarathene
polarathene previously approved these changes Mar 3, 2022
View reviewed changes
Comment thread target/scripts/startup/setup-stack.sh Outdated
@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Mar 3, 2022

We could also add to the docs that a value of 0 disables the limit.

@casperklein casperklein dismissed stale reviews from polarathene and georglauterbach via a477f80 March 3, 2022 10:59
@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented Mar 3, 2022

We could also add to the docs that a value of 0 disables the limit.

From the clamav man page: Warning: disabling this limit or setting it too high may result in severe damage to the system.
I've found also a nice explanation, why this is a bad idea.

If someone really wants to disable the limit, reading the man page should be mandatory.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2022

Documentation preview for this PR is ready! 🎉

Built with commit: 84d91bc

@casperklein casperklein merged commit b9fdb1e into docker-mailserver:master Mar 3, 2022
@casperklein casperklein deleted the fix-2450 branch March 3, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels

area/scripts kind/new feature A new feature is requested in this issue or implemeted with this PR

Projects

None yet

Milestone

v11.0.0

Development

Successfully merging this pull request may close these issues.

message_size_limit does not change clamd.conf MaxFileSize

3 participants

@casperklein @georglauterbach @polarathene