Skip to content

macos support: lint.sh doesn't find proper bash under /usr/local/bin + acme_extract (python) is trying to be shellchecked#2448

Merged
NorseGaud merged 6 commits intomasterfrom
macos-linting-support
Mar 2, 2022
Merged

macos support: lint.sh doesn't find proper bash under /usr/local/bin + acme_extract (python) is trying to be shellchecked#2448
NorseGaud merged 6 commits intomasterfrom
macos-linting-support

Conversation

@NorseGaud
Copy link
Copy Markdown
Member

Description

  1. shopt -s inherit_errexit is only a bash >= 4.x feature. Apple still hasn't updated bash from 3.x, but you can (and we tell contributors to in our docs) install 5.x. This installs into /usr/local/bin. However, when I go to run make lint, it fails at the shopt line.

  2. acme_extract is being scanned by shellcheck due to permissions differences and throwing

In target/bin/acme_extract line 1:
#!/usr/bin/env python3
^-- SC1071 (error): ShellCheck only supports sh/bash/dash/ksh scripts. Sorry!

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Comment thread test/linting/lint.sh Outdated
Copy link
Copy Markdown
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NorseGaud NorseGaud merged commit 1eca829 into master Mar 2, 2022
@NorseGaud NorseGaud deleted the macos-linting-support branch March 2, 2022 22:34
@NorseGaud NorseGaud mentioned this pull request Mar 4, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants