tests: remove legacy functions / tests#2434
Merged
casperklein merged 6 commits intodocker-mailserver:masterfrom Mar 2, 2022
Merged
tests: remove legacy functions / tests#2434casperklein merged 6 commits intodocker-mailserver:masterfrom
casperklein merged 6 commits intodocker-mailserver:masterfrom
Conversation
martin-schulze-vireso
approved these changes
Feb 23, 2022
Contributor
There was a problem hiding this comment.
LGTM
Its funny how this issue made me end up as maintainer of Bats... Nice to see my work bear fruit. Thanks @ALL for giving docker-mailserver new drive.
georglauterbach
approved these changes
Feb 23, 2022
Member
georglauterbach
left a comment
There was a problem hiding this comment.
Very nince! This was bothering me for a long time now.
polarathene
approved these changes
Feb 23, 2022
wernerfred
approved these changes
Feb 23, 2022
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In old bats versions, there was no native support for the
setup_file,teardown_filefunctions. To get this working, workaround functions and dummy tests (@test "first, @test "last") were added.Since our bats version does support those functions out-of-the-box for some time now and there is no need for the dummy functions / test anymore, they have been removed.
CI: This will also remove plenty of message like this while running the tests:
ok 5 first # skip This version natively supports setup/teardown_file@martin-schulze-vireso IIRC, you wrote most of these tests. I wasn't able to add you as a reviewer, but you might also take a look and confirm, if everything is alright.
Type of change
Checklist:
docs/)