Adjust envrionment variables - more sensible defaults#2428
Merged
georglauterbach merged 11 commits intomasterfrom Mar 2, 2022
Merged
Adjust envrionment variables - more sensible defaults#2428georglauterbach merged 11 commits intomasterfrom
georglauterbach merged 11 commits intomasterfrom
Conversation
The new setup will now set env variables on one place and on one place only. The old setup used two separate places wich is not DRY and confusing. Some default values changed: 1. PFLOGSUMM_TRIGGER: logrotate => none 2. REPORT_SENDER: mailserver-report@HOSTNAME => mailserver-report@DOMAIN 3. REPORT_RECIPIENT: "0" => POSTMASTER_ADDRESS One env variable was renamed: REPORT_INTERVAL => LOGROTATE_INTERVAL I believe these defaults to be more sensible, especially the REPORT_RECIPIENT address. The PFLOGSUMM_TRIGGER value was changed to `none` because otherwise people would start getting daily Postfix log summary reports automatically. Now, this is opt-in, and reports are sent only when enabled properly. Some of the variables changed were marked as deprecated. I removed the note, as the variables now bear some (sane) defaults again for other variables (i.e.) REPORT_RECIPIENT is now default for other recipient addresses. Although some defaults changed, this is not a breaking change as the mail server starts exactly as before. Even for REPORT_RECIPIENT="0" explictly set, other reports are opt-in as well with their defaults, and as the recipient default changed, this is fine as well.
georglauterbach
requested review from
casperklein,
polarathene and
wernerfred
georglauterbach
added
area/scripts
kind/improvement
polarathene
requested changes
Feb 21, 2022
polarathene
previously approved these changes
Feb 22, 2022
Member
Author
|
@polarathene @casperklein @wernerfred do you think this can go into |
Member
|
Refactoring is 10.4.1 but changing the Default is 11.0 from my point of view |
6 tasks
Member
Author
|
As much as I'd like to see this in EDIT: I put this into the |
georglauterbach
added
the
meta/feature freeze
casperklein
requested changes
Feb 22, 2022
Co-authored-by: Casper <[email protected]>
casperklein
reviewed
Feb 22, 2022
casperklein
reviewed
Feb 23, 2022
Co-authored-by: Casper <[email protected]>
casperklein
reviewed
Feb 25, 2022
polarathene
previously approved these changes
Feb 25, 2022
casperklein
previously approved these changes
Feb 25, 2022
georglauterbach
removed
the
meta/feature freeze
georglauterbach
dismissed stale reviews from casperklein and polarathene
via
f4d9b01
Contributor
|
Documentation preview for this PR is ready! 🎉 Built with commit: a6e2bd1 |
casperklein
approved these changes
Mar 2, 2022
polarathene
approved these changes
Mar 2, 2022
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The new setup will now set env variables in one place and in one place
only. The old setup used two separate places wich is not DRY and
confusing.
Some default values changed:
PFLOGSUMM_TRIGGER: logrotate => noneREPORT_SENDER: mailserver-report@HOSTNAME => mailserver-report@DOMAINREPORT_RECIPIENT: "0" =>POSTMASTER_ADDRESSLOGROATE_INTERVAL:daily=>weeklyOne env variable was renamed:
REPORT_INTERVAL=>LOGROTATE_INTERVALI believe these defaults to be more sensible, especially the REPORT_RECIPIENT
address. The PFLOGSUMM_TRIGGER value was changed to
nonebecause otherwisepeople would start getting daily Postfix log summary reports automatically.
Now, this is opt-in, and reports are sent only when enabled properly.
Some of the variables changed were marked as deprecated. I removed the note,
as the variables now bear some (sane) defaults again for other variables
(i.e.)
REPORT_RECIPIENTis now default for other recipient addresses.Although some defaults changed, this is not a breaking change as the
mail server starts exactly as before. Even for REPORT_RECIPIENT="0"
explictly set, other reports are opt-in as well with their defaults,
and as the recipient default changed, this is fine as well.
I would leave it up to vote whether this PR qualifies for
10.5.0or for11.0.0. I'm also open to other defaults, although I think they're okay as they are. Please watch out for inconsistencies in the documentation :DType of change
Checklist:
docs/)