fix: do not add accounts that already exists to account files#2419
Merged
georglauterbach merged 10 commits intomasterfrom Feb 21, 2022
Merged
fix: do not add accounts that already exists to account files#2419georglauterbach merged 10 commits intomasterfrom
georglauterbach merged 10 commits intomasterfrom
Conversation
georglauterbach
added
priority/medium
service/dovecot
service/postfix
area/scripts
kind/improvement
georglauterbach
requested review from
a team,
NorseGaud,
casperklein,
polarathene and
wernerfred
Somehow I forgot to check for aliases (which actually caused the original issue to be opened...). This commit fixes the issue properly and also introduces warning messages when aliases or accountts are about to be added twice.
This was referenced Feb 18, 2022
casperklein
reviewed
Feb 18, 2022
Co-authored-by: Casper <[email protected]>
Member
Author
|
Cancelled the current workflow because I will push another commit soon. I don't like wasting compute time (even if it's not mine 😆) |
casperklein
reviewed
Feb 19, 2022
casperklein
previously approved these changes
Feb 20, 2022
polarathene
requested changes
Feb 20, 2022
Co-authored-by: Brennan Kinney <[email protected]>
7 tasks
casperklein
approved these changes
Feb 21, 2022
polarathene
approved these changes
Feb 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Includes a fix with which users are not added to the accounts files of Postfix and Dovecot if they are already present.
Fixes #2416
Type of change
Checklist:
docs/)