Skip to content

fix: double occurence of /etc/postfix/regexp#2397

Merged
georglauterbach merged 6 commits intomasterfrom
fix/issue-2394
Feb 11, 2022
Merged

fix: double occurence of /etc/postfix/regexp#2397
georglauterbach merged 6 commits intomasterfrom
fix/issue-2394

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Feb 7, 2022

Description

/etc/postfix/regexp appeared twice in Postfix's virtual_alias_maps. This should be corrected now.

PS: It turns out, without this PR, every time a change is detected, /etc/postfix/regexp will be added again. So this PR is indeed somewhat important :D

Fixes #2394

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach
Copy link
Copy Markdown
Member Author

Seems like I broke something. I will have a look again.

@casperklein casperklein marked this pull request as draft February 7, 2022 13:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 7, 2022

Documentation preview for this PR is ready! 🎉

Built with commit: 0ae2da2

@georglauterbach georglauterbach marked this pull request as ready for review February 7, 2022 21:25
Comment thread target/scripts/startup/setup-stack.sh Outdated
@georglauterbach georglauterbach requested review from a team and casperklein February 8, 2022 11:45
casperklein
casperklein previously approved these changes Feb 8, 2022
@georglauterbach georglauterbach requested review from a team and polarathene February 8, 2022 12:02
Copy link
Copy Markdown
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Just one typo (not from this PR but that existed before with the warning file path being incorrect).

Comment thread target/scripts/startup/setup-stack.sh Outdated
@georglauterbach
Copy link
Copy Markdown
Member Author

I'd like to release v10.5.0 when this PR and #2361 are merged :D

Copy link
Copy Markdown
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@georglauterbach georglauterbach merged commit ce9e86c into master Feb 11, 2022
@georglauterbach georglauterbach deleted the fix/issue-2394 branch February 11, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] virtual_alias_maps contains the regexp entry multiple times

4 participants