tests(fix): Align with upstream testssl field name change#2353
Merged
polarathene merged 2 commits intomasterfrom Jan 1, 2022
Merged
tests(fix): Align with upstream testssl field name change#2353polarathene merged 2 commits intomasterfrom
testssl field name change#2353polarathene merged 2 commits intomasterfrom
Conversation
The field name to check in JSON output was recently changed for the cipherlist results, causing tests to fail.
11 tasks
casperklein
approved these changes
Jan 1, 2022
georglauterbach
approved these changes
Jan 1, 2022
Member
|
Linking to #2354 which does what this PR does and more. Maybe close this PR? |
Member
|
I would keep/merge this PR. Both PRs fixes separate issues. |
This comment was marked as outdated.
This comment was marked as outdated.
polarathene
deleted the
tests/fix-cipherlist-match-testssl-upstream-change
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The field name to check in JSON output was recently changed for the cipherlist results, causing tests to fail.
This should resolve the current test failure for an open PR. Although the change was 3 weeks ago, it's only appearing now I think as releases (or updated builds of
3.1-devrather) being published to DockerHub was handled manually, they now have a paid subscription for automated builds which was announced in the past 12 hours, with new image updates.It's unclear when the
3.2release will arrive, but3.0has seen a final / non-rc release back in October, it's apparently missing out on all of this from3.1-dev, but seems to be compatible with our tests if you'd rather we switch to that stable tag instead of the rolling release3.1-dev. Both images received the JSON field change as a fix,so that change is required regardless.Type of change
Checklist: