Removed Dovecot stats configuration for old statistics plugin#2336
Merged
georglauterbach merged 1 commit intomasterfrom Dec 20, 2021
Merged
Removed Dovecot stats configuration for old statistics plugin#2336georglauterbach merged 1 commit intomasterfrom
georglauterbach merged 1 commit intomasterfrom
Conversation
4 tasks
polarathene
approved these changes
Dec 20, 2021
casperklein
approved these changes
Dec 20, 2021
8 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(Running the latest
:edgeimage.)I accepted the
v10.4PR too fast and got the paycheck :D I just went over my logs and saw the lineso I had a look again. Turns out, the old stats plugin is deprecated and it suffices to disable the new Dovecot stats. The old stats plugin was opt-in (via
mail_plugins = $mail_plugins imap_quota) but we have not configured this anywhere so the old stats were never active. I guess Dovecot gets confused when it encounters the config for the old plugin which is not even enabled.Nothing serious but nothing that should be in your log either. I would like to see this in
v10.4so there is no actual (semi-)regression on a stable release tag. Maybe someone can even confirm?Sources: https://doc.dovecot.org/installation_guide/upgrading/from-2.2-to-2.3/?highlight=stats%20plugin
Fixes a semi-regression introduced in #2292
Type of change
Checklist:
docs/)