Skip to content

Removed Dovecot stats configuration for old statistics plugin#2336

Merged
georglauterbach merged 1 commit intomasterfrom
fix/dovecot-old-stats
Dec 20, 2021
Merged

Removed Dovecot stats configuration for old statistics plugin#2336
georglauterbach merged 1 commit intomasterfrom
fix/dovecot-old-stats

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Dec 20, 2021

Description

(Running the latest :edge image.)

I accepted the v10.4 PR too fast and got the paycheck :D I just went over my logs and saw the line

dovecot: auth: Error: stats: open(old-stats-user) failed: No such file or directory

so I had a look again. Turns out, the old stats plugin is deprecated and it suffices to disable the new Dovecot stats. The old stats plugin was opt-in (via mail_plugins = $mail_plugins imap_quota) but we have not configured this anywhere so the old stats were never active. I guess Dovecot gets confused when it encounters the config for the old plugin which is not even enabled.

Nothing serious but nothing that should be in your log either. I would like to see this in v10.4 so there is no actual (semi-)regression on a stable release tag. Maybe someone can even confirm?

Sources: https://doc.dovecot.org/installation_guide/upgrading/from-2.2-to-2.3/?highlight=stats%20plugin

Fixes a semi-regression introduced in #2292

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants