Skip to content

make Bash start user-patches.sh#2295

Merged
georglauterbach merged 3 commits intomasterfrom
user-patches-improvement
Nov 13, 2021
Merged

make Bash start user-patches.sh#2295
georglauterbach merged 3 commits intomasterfrom
user-patches-improvement

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented Nov 12, 2021

Description

This addition is somewhat important for K8s users and changes nothing in terms of functionality. We currently execute the user-patches.sh script with a shebang, making it executable beforehand if it wasn't to begin with.

Now, Bash will take the script and execute it. This change has therefore no implications on the actual execution of the user-patches.sh script.

But for Kubernetes users, this way of executing the script is the most comfortable one because all others are somewhat tiresome or involve unnecessary work! The explanation:

You would mount this script via a ConfigMap into the container. These files are by default not executable and one cannot change the permissions. One would need to specify the permissions for this ConfigMap but then you'd do this for all files of this ConfigMap, which is not necessarily desirable either. By using Bash and supplying it the script, we can solve this problem with ease!

I marked this as high priority because I need this change to be in :edge ASAP :D Please review!

Fixes permissions error for Kubernetes users (user-patches.sh).

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach added priority/high area/scripts kind/improvement Improve an existing feature, configuration file or the documentation labels Nov 12, 2021
@georglauterbach georglauterbach added this to the v10.3.0 milestone Nov 12, 2021
@georglauterbach georglauterbach self-assigned this Nov 12, 2021
@georglauterbach
Copy link
Copy Markdown
Member Author

Manually cancelled the first two CI pipelines, no worries there :)

@georglauterbach georglauterbach merged commit 6c1c669 into master Nov 13, 2021
@georglauterbach georglauterbach deleted the user-patches-improvement branch November 13, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/scripts kind/improvement Improve an existing feature, configuration file or the documentation priority/high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants