make Bash start user-patches.sh#2295
Merged
georglauterbach merged 3 commits intomasterfrom Nov 13, 2021
Merged
Conversation
This reverts commit c5261b0.
Member
Author
|
Manually cancelled the first two CI pipelines, no worries there :) |
polarathene
approved these changes
Nov 12, 2021
casperklein
approved these changes
Nov 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addition is somewhat important for K8s users and changes nothing in terms of functionality. We currently execute the
user-patches.shscript with a shebang, making it executable beforehand if it wasn't to begin with.Now, Bash will take the script and execute it. This change has therefore no implications on the actual execution of the
user-patches.shscript.But for Kubernetes users, this way of executing the script is the most comfortable one because all others are somewhat tiresome or involve unnecessary work! The explanation:
You would mount this script via a
ConfigMapinto the container. These files are by default not executable and one cannot change the permissions. One would need to specify the permissions for thisConfigMapbut then you'd do this for all files of thisConfigMap, which is not necessarily desirable either. By using Bash and supplying it the script, we can solve this problem with ease!I marked this as high priority because I need this change to be in
:edgeASAP :D Please review!Fixes permissions error for Kubernetes users (
user-patches.sh).Type of change
Checklist:
docs/)