Skip to content

Fix OpenDMARC verification#2291

Merged
georglauterbach merged 1 commit intodocker-mailserver:masterfrom
eglia:fix-opendmarc-hostname
Nov 10, 2021
Merged

Fix OpenDMARC verification#2291
georglauterbach merged 1 commit intodocker-mailserver:masterfrom
eglia:fix-opendmarc-hostname

Conversation

@eglia
Copy link
Copy Markdown
Contributor

@eglia eglia commented Nov 9, 2021

Description

Removes the quotation marks around the hostname in opendmarc.conf .
OpenDMARC includes the quotation marks in the hostname, and therefore the hostname no longer matches the header added by OpenDKIM. OpenDMARC then ignores the header and fails the authentication.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@eglia eglia changed the title Fix OpenDMARCverification Fix OpenDMARC verification Nov 9, 2021
@georglauterbach
Copy link
Copy Markdown
Member

Woah, these are the lines stating

opendmarc | ... ignoring Authentication-Results at 1 from ...

? I was already wondering, but all seemed to work well. Very nice!

@georglauterbach georglauterbach requested a review from a team November 10, 2021 08:43
@georglauterbach georglauterbach merged commit e436968 into docker-mailserver:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants