fix: Monitor for changes in supported letsencrypt locations#2279
Merged
polarathene merged 3 commits intodocker-mailserver:masterfrom Nov 4, 2021
Merged
Conversation
Previously we only monitored for `$HOSTNAME` in `/etc/letsencrypt/live` and only for hard-coded `.pem` filenames. This ensures we check the locations of other locations that may not match `$HOSTNAME`, which we also support. Ideally in future at least the directory to look in would be better known..
This comment has been minimized.
This comment has been minimized.
Member
|
👍 for putting a large PR into smaller pieces. |
casperklein
previously approved these changes
Nov 1, 2021
Co-authored-by: Casper <[email protected]>
casperklein
approved these changes
Nov 1, 2021
polarathene
added
area/scripts
kind/bug
kind/improvement
7 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This has been extracted from #2245 as it does not need to be part of that PR. It is related to addressing the problem, but I'm opting to piece-meal extract the bulk of the original PR out for easier review.
This fix is all @NorseGaud with minor fix by quote wrapping the vars and adding comments by me.
Previously we only monitored for
$HOSTNAMEin/etc/letsencrypt/liveand only for hard-coded.pemfilenames.This ensures we check the locations of other locations that may not match
$HOSTNAME, which we also support. Ideally in future at least the directory to look in would be better known in advance..Current test failure is due to the lack of quote wrapping vars in
check-for-changes.shloop whenSSL_DOMAINcontains a wildcard prefix (*.) for the FQDN. That was fixed in #2274 , once that's merged the test will pass.Type of change
Checklist: