tests(feat): Refactor test_helper/common.bash common_container methods#2275
Merged
polarathene merged 7 commits intodocker-mailserver:masterfrom Nov 4, 2021
Conversation
These are improvements for better supporting the requirements of other tests. - Opted for passing an array reference instead of an ENV file. This seems to be a better approach and supports more than just ENV changes. - Likewise, shifted to a `create` + `start` approach, instead of `docker run` for added flexibility. - Using `TEST_TMP_CONFIG` instead of `PRIVATE_CONFIG` to make the difference in usage with config volume in tests more clear. - Changed the config volume from read-only volume mount to be read-write instead, which seems required for other tests. - Added notes about logged failures from a read-only config volume during container startup. - Added `TEST_CA_CERT` as a default CA cert path for the test files volume. This can be used by default by openssl methods.
Member
georglauterbach
left a comment
georglauterbach
left a comment
There was a problem hiding this comment.
Just one or two questions; not that good at bats myself TBH.
11 tasks
polarathene
added
area/tests
kind/improvement
7 tasks
- Quote wrap the array var name being passed to be referenced by helper method. - Better document common_container helper methods.
polarathene
force-pushed
the
tests/improve-container-template-helper
branch
from
2977ced to
d8644fb
Compare
Member
Author
I'd prefer to keep the current approach for now. Can change to |
casperklein
approved these changes
Nov 4, 2021
Member
|
I think you @polarathene and I just updated the branch at the same time. My commit does the same, but has no changes 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This has been extracted from #2245 as it does not need to be part of that PR.
These are improvements for better supporting the requirements of other tests.
create+startapproach, instead ofdocker runfor added flexibility.TEST_TMP_CONFIGinstead ofPRIVATE_CONFIGto make the difference in usage with config volume in tests more clear.TEST_CA_CERTas a default CA cert path for the test files volume. This can be used by default by openssl methods.Type of change
Checklist:
docs/)