fix: ONE_DIR=1 should keep correct permissions for spool-postfix#2273
Merged
polarathene merged 1 commit intodocker-mailserver:masterfrom Oct 31, 2021
Merged
Conversation
GID of postfix(102) should not be set here. only GID is root(0) and postdrop(103). Ensure root(0) UID matches source location ownership too.
32ac515 to
995cbce
Compare
georglauterbach
approved these changes
Oct 31, 2021
Member
georglauterbach
left a comment
There was a problem hiding this comment.
LGTM
I had this in my user-patches.sh because I thought this was K8s related. Nice 👍🏼
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A PR in July 2017 contained a fix for this but was rejected due to other changes proposed:
I have looked at the source destination and the permissions remain the same. This PR carries over the ownership to the
ONE_DIRlocation.An alternative fix in future might be to use
rsyncwhich can copy over the contents with permissions and everything else retained. I'm not super familiar with theONE_DIRhandling myself. I see that it appears to do some cleanup and mostly symlinking (for files?) and moving for directories?I came across this when looking into
postdropin regards tomaildropwhile working on this PR.postdrop:postdrophangs.Fixes #694 #1029 #1179
Affected a vacation sieve filter in Sep 2018 and a sieve filter redirect in June 2019:
Type of change
Checklist:
docs/)