chore: Remove invalid/redundant config in Postfix master.cf#2272
Merged
polarathene merged 2 commits intodocker-mailserver:masterfrom Nov 1, 2021
Merged
Conversation
This was all introduced by the original project author early on, no explanation for it. None of the paths they use as `argv` values exist. `uucp` doesn't seem relevant to the project. No justification for it, no issues or PRs in project history or codebase.
7 tasks
georglauterbach
approved these changes
Oct 31, 2021
casperklein
approved these changes
Oct 31, 2021
7 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This was all introduced by the original project author early on (April 2015), no explanation for it. Seems safe to remove.
argvvalues exist.uucpdoesn't seem relevant to the project. No justification for it, no issues or PRs in project history or codebase.mailmanis for managing mailing lists, we do have issues requesting support in May 2020 and Nov 2016. Debian 11 Bullseye also no longer includes amailmanpackage, there ismailman3andmailman3-full, assuming anyone wants to add that, they can add the assumed requiredmaster.cfline back and any other configuration they need, we don't officially support such.maildrop, this is different from the maildrop queue in/var/spool/postfix/maildropthatpostdrophandles AFAIK. Especially since we can see the guide advises settingvirtual_transporttomaildropwhich we have already configured to be LMTP with Dovecot. As the binary itself doesn't exist at the configured path, if this ever worked it hasn't been for a while presumably.. and no issue or PR github tracker history, nor content in the project files.scalemailbriefly via log failure, that was back in Sep 2016, I don't know what the setup was like back then and perhaps this was something that was in the image prior to transition to Debian, or they added it themselves. The issue was regarding permissions withONE_DIRENV, that was AFAIK resolved via thechown -Rfixes script.I have not looked through anything else in
master.cf, just housekeeping.Type of change
Not likely:
Checklist:
docs/)