Fixed KeyTable refile in opendkim.conf https://serverfault.com/a/8617…#2249
Fixed KeyTable refile in opendkim.conf https://serverfault.com/a/8617…#2249georglauterbach merged 2 commits intodocker-mailserver:masterfrom frugan-dev:master
Conversation
There was a problem hiding this comment.
This seems fine, thanks for the contribution! :)
refile: was added in the original PR introducing DKIM support which was for resolving a feature request by that same PR author, where they reference a install guide that uses refile: and I assume is the source of that choice.
I'm not aware of any valid reason we'd want regex support for KeyTable file after looking into it briefly and reviewing our usage/support.
Our opendkim tests look a tad concerning though 😅 , I'll probably address that once I start refactoring the test suite.
More info on opendkim tests needing refactor, seems when I've refactored the test suite this should be easier to support as I intend to have a proper DNS (with actual records) setup for more real-world test environment.
Description
opendkim-testkey -vvreturns errorinvalid data set type.By removing
refile:from/etc/opendkim.confthe problem seems to be solved, as explained here https://serverfault.com/a/861701/377751.Before:
After:
Type of change
Checklist:
docs/)