docs(CONTRIBUTORS): update contributors#2218
docs(CONTRIBUTORS): update contributors#2218github-actions[bot] wants to merge 1 commit intomasterfrom
Conversation
|
@casperklein same issue again. I have an idea what might be the problem and will investigate today. |
|
BTW: I think we should increase the run interval from daily to weekly|monthly to reduce the PR noise 😉 |
|
So my guess was that the required checks have a problem like we had earlier (earlier the test workflow was required too but didn't run on for example doc update PRs as the workflow explicit exclude changes to markdown files of triggering the workflow) Currently linting is the only required check: Where the worklow should run on every PR: docker-mailserver/.github/workflows/linting.yml Lines 3 to 8 in 88a1619 So my initial guess that we have the same problem again doesn't seem to be the case. Weirdly enough last time it worked from the moment i did a push to the branch, to the same file. So liniting will trigger correctly even for this file. So new guess here: From my experience with a lot of different workflow files and github actions i remember that a workflow cannot trigger another workflow by default. This could be the case here as the PR originates from another workflow that runs. IIRC we have two options:
Maybe someone can confirm? @polarathene? I am able to look into this and try to solve it but unfortunately not today and probably not before next week. So if someone wants to jump in feel free otherwise maybe set it to monthly @casperklein which gives me time to fix the current issue and can be reduced to weekly again if its working EDIT: Here is a link for reference: https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#triggering-new-workflows-using-a-personal-access-token And we would need a PAT for option 2. as well. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Triggering the lint workflow did work. However I think, this lint-run is not "connected" to the PR #2223 the workflow created. Same problem: peter-evans/create-pull-request#48 (comment) If I understand correctly, this must be updated to use a PAT: |
|
Workaround: Closing and reopening the PR triggers the lint-test 😄 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Three options to explore, I've created a PR for the last one. If that doesn't work, I don't have time to attempt the other two. create-pull-requests action resource, prefer SSH deploy keys or Github App token over PATLooked into it and came across some good docs for a Instead of a PAT, they advise SSH deploy keys which allows for reduced scope permissions vs a PAT, but only triggers Workflows via I don't know how well that gels with your existing workflow and actions. Another option they detail is generating token via Github App, which again is preferable to using a PAT. workflow_dispatch and repository_dispatch actions to trigger the lint workflowAlternatively, after the contributor workflow is done, we could trigger a workflow dispatch event, this allows the contributor workflow to "manually" trigger the lint workflow, but AFAIK requires a PAT. Requires a git branch or tag name for For There's also this Final option that might work if we actually don't care about running the linting workflow: Rough workflow snippet- name: 'Get the latest commit hash from the contributors-update branch'
id: commit-data
run: 'echo "::set-output name=head_sha::$(git rev-parse contributors-update)"'
- name: 'Commit Status: Set Lint status to success (skipped)'
uses: myrotvorets/[email protected]
with:
token: ${{ secrets.GITHUB_TOKEN }}
# If the Lint workflow did run and was skipped instead, it'd still assign a "success" status. This should be valid:
status: success
# This should be the correct commit SHA on the contributors-update branch
sha: ${{ steps.commit-data.outputs.head_sha }}
# Name of status check to add/update
context: 'lint'
# Optional message/note we can inline to the right of the context name in the UI:
description: "Lint skipped. Not applicable." |
|
Hopefully the new PR solution works 🙏 |

docs(CONTRIBUTORS): update contributors