Follow up on PR for fixing tests (mostly styling)#2180
Merged
polarathene merged 1 commit intomasterfrom Sep 11, 2021
Merged
Conversation
georglauterbach
added
priority/low
area/tests
kind/improvement
georglauterbach
requested review from
NorseGaud,
casperklein and
polarathene
casperklein
approved these changes
Sep 11, 2021
polarathene
approved these changes
Sep 11, 2021
Member
|
@NorseGaud what did you do to trigger those commit references? They tag me via notification because my username is mentioned, and likewise the PR reference (no notification for me) appears on this PR and referenced one. Is this something Github is doing when you updated a branch/PR of yours? |
Member
|
@polarathene Woh... I actually don't know... I've never seen these before. Very strange... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just a follow up on #2177 with suggestions from @polarathene.
Type of change
Checklist:
docs/)