Skip to content

feat: rootless Podman with documentation#2179

Merged
georglauterbach merged 12 commits intodocker-mailserver:masterfrom
OrvilleQ:feat/rootless-podman
Sep 19, 2021
Merged

feat: rootless Podman with documentation#2179
georglauterbach merged 12 commits intodocker-mailserver:masterfrom
OrvilleQ:feat/rootless-podman

Conversation

@OrvilleQ
Copy link
Copy Markdown
Contributor

Description

Setup.sh : Add ability to operate rootless podman.

Doc: Add guide for Podman and Root-less Podman

Fixes #2178

Type of change

  • Improvement (non-breaking change that does improve existing functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach added area/documentation kind/improvement Improve an existing feature, configuration file or the documentation meta/needs triage This issue / PR needs checks and verification from maintainers orchestrator/podman priority/low labels Sep 10, 2021
@georglauterbach
Copy link
Copy Markdown
Member

I will mark this as WIP as long as #2174 is not merged because #2174 is important. You will then likely need to rebase onto master. Reviews can then be provided. In the meantime, I'd like to discuss this topic in the linked issue #2178.

@georglauterbach georglauterbach marked this pull request as draft September 10, 2021 08:29
Comment thread docs/content/config/advanced/podman.md Outdated
Comment thread setup.sh Outdated
- More detailed port forwarding guide.
- Fix spelling errors.
- Standardized technical terms. (Rootfull & Rootless)
@georglauterbach georglauterbach marked this pull request as ready for review September 16, 2021 07:38
@georglauterbach georglauterbach added this to the v10.2.0 milestone Sep 16, 2021
@georglauterbach
Copy link
Copy Markdown
Member

I have adjusted to documentation :) @polarathene what do you think of this PR?

wernerfred
wernerfred previously approved these changes Sep 16, 2021
Copy link
Copy Markdown
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📚 👍🏻

@georglauterbach
Copy link
Copy Markdown
Member

@wernerfred I messed up setup.sh for a second with one of my commits. Please review again :)

@georglauterbach
Copy link
Copy Markdown
Member

NOTE Tests for merge requests are currently expected to fail. When #2189 is merged, tests should pass again.

@georglauterbach georglauterbach changed the title Feat/Root-less Podman feat: rootless Podman with documentation Sep 16, 2021
wernerfred
wernerfred previously approved these changes Sep 16, 2021
@casperklein
Copy link
Copy Markdown
Member

setup.sh is non-interactive and all configuration is based on parameters. Why switching to interactive for podman?

This makes it harder, if you use setup.sh in an automated way. There should be an "rootless" option, when calling setup.sh.

@georglauterbach
Copy link
Copy Markdown
Member

setup.sh is non-interactive and all configuration is based on parameters. Why switching to interactive for podman?

This makes it harder, if you use setup.sh in an automated way. There should be an "rootless" option, when calling setup.sh.

Agreed. I thought about exactly the same when doing the change. But should be done with another PR :)

@georglauterbach
Copy link
Copy Markdown
Member

Unexpected test failure:

 not ok 296 checking system: postfix should not log to syslog
# (from function `assert_failure' in file test/test_helper/bats-assert/src/assert.bash, line 140,
#  in test file test/tests.bats, line 549)
#   `assert_failure' failed
# 
# -- command succeeded, but it was expected to fail --
# output : Sep 16 09:33:13 mail postfix/postfix-script[2669]: fatal: the Postfix mail system is already running
# --
# 

Re-run the tests?

@wernerfred
Copy link
Copy Markdown
Member

But should be done with another PR :)

Why not change it now?

@georglauterbach
Copy link
Copy Markdown
Member

@wernerfred I'd rather like to have a look at the whole "argument" parsing TBH. Therefore, I'd like to see the functionality being preserved with this PR and change with a follow-up.

@georglauterbach georglauterbach added pr/waiting for other PR to get merged This PR is waiting for another / other PR(s) to get merged and removed meta/needs triage This issue / PR needs checks and verification from maintainers labels Sep 19, 2021
@georglauterbach georglauterbach dismissed stale reviews from wernerfred and themself via c131f2b September 19, 2021 16:45
@georglauterbach
Copy link
Copy Markdown
Member

I have completely removed the changes to setup.sh as I will provide a dedicated PR for that.

@github-actions
Copy link
Copy Markdown
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: 484b30d

@georglauterbach georglauterbach enabled auto-merge (squash) September 19, 2021 16:48
@georglauterbach georglauterbach merged commit ddd9727 into docker-mailserver:master Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation kind/improvement Improve an existing feature, configuration file or the documentation orchestrator/podman pr/waiting for other PR to get merged This PR is waiting for another / other PR(s) to get merged priority/low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FR] document how to run in rootless Podman

5 participants