Move setup process via script into container#2174
Conversation
|
MkDocs does not seem to render ~~ (crossed out) correctly. @wernerfred @polarathene do you have any idea how to fix this? I mean, it's just a joke in the docs and we can remove it, but it makes me curious. |
Co-authored-by: Brennan Kinney <[email protected]>
Co-authored-by: Brennan Kinney <[email protected]>
|
@docker-mailserver/maintainers Tests should pass again (rebased on |
casperklein
left a comment
There was a problem hiding this comment.
See my suggestions to remove MacOS specific quirks, intruduced in #2001
Co-authored-by: Casper <[email protected]>
Co-authored-by: Casper <[email protected]>
Co-authored-by: Casper <[email protected]>
Co-authored-by: Casper <[email protected]>
Co-authored-by: Casper <[email protected]>
Co-authored-by: Casper <[email protected]>
Co-authored-by: Casper <[email protected]>
|
Documentation preview for this PR is ready! 🎉 Built with commit: 512de25 |
|
I have updated the blog post to cover the new conditions regarding setup. I'd also like to take the opportunity to thank you for your efforts! |
You're welcome! :) You blog post was the reason I actually started this as it was very valid and hard (but correct, which I appreciate) criticism. Thanks! |
Description
Decoupling setup process from
setup.shscript by introducing a setup script inside the container that coordinates the setup process. This is not a breaking change. This way, we do not have to keep track of versions ofsetup.sh, which was said to be a no-no here. This is a blog post we're linking to in our documentation. This change brings the additional benefit for Kubernets users to be able to make use ofsetupnow, without the need forsetup.sh.The maintainers discussion referencing / talking about the current
setup.shversioning-problem can be found here.This PR was really made possible by @NorseGaud with #2134
Type of change
Checklist:
docs/)