Skip to content

Update delmailuser to allow mailboxes without TLD#2172

Merged
georglauterbach merged 4 commits intodocker-mailserver:masterfrom
danielvandenberg95:master
Sep 9, 2021
Merged

Update delmailuser to allow mailboxes without TLD#2172
georglauterbach merged 4 commits intodocker-mailserver:masterfrom
danielvandenberg95:master

Conversation

@danielvandenberg95
Copy link
Copy Markdown
Contributor

@danielvandenberg95 danielvandenberg95 commented Sep 5, 2021 •
edited
Loading

Description

Don't allow invalid email addresses in addmailuser.

Fixes #2171

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein
Copy link
Copy Markdown
Member

casperklein commented Sep 5, 2021

Thank you for your contribution. You can create mailboxes without a TLD. So fixing delmailuser instead seems more appropriate to me.

@casperklein casperklein changed the title Update addmailuser Update delmailuser Sep 5, 2021
@danielvandenberg95
Copy link
Copy Markdown
Contributor Author

danielvandenberg95 commented Sep 5, 2021

Changed. (Please squash merge when merging, to prevent commits showing up on addmailuser.)

@casperklein casperklein added this to the v10.1.3 milestone Sep 5, 2021
@casperklein casperklein added area/scripts kind/improvement Improve an existing feature, configuration file or the documentation labels Sep 5, 2021
@NorseGaud NorseGaud self-requested a review September 5, 2021 23:17
NorseGaud
NorseGaud previously requested changes Sep 5, 2021
View reviewed changes
Comment thread target/bin/delmailuser
@NorseGaud NorseGaud changed the title Update delmailuser Update delmailuser to allow mailboxes without TLD Sep 5, 2021
@georglauterbach georglauterbach modified the milestones: v10.1.3, v10.2.0 Sep 6, 2021
@NorseGaud NorseGaud removed their request for review September 9, 2021 03:37
@NorseGaud NorseGaud dismissed their stale review September 9, 2021 03:38

Nevermind

@georglauterbach georglauterbach merged commit 00c8a7b into docker-mailserver:master Sep 9, 2021
@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented Sep 9, 2021

@casperklein You can go ahead and provide the PR you mentioned in the comments :)

@casperklein casperklein mentioned this pull request Sep 11, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

+1 more reviewer

@NorseGaud NorseGaud NorseGaud left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@danielvandenberg95 danielvandenberg95

Labels

area/scripts kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Milestone

v10.2.0

Development

Successfully merging this pull request may close these issues.

[BUG] No valid mail address in remove, after making email.

4 participants

@danielvandenberg95 @casperklein @georglauterbach @NorseGaud