Introduce issue forms and update debug output for forms by georglauterbach · Pull Request #2160 · docker-mailserver/docker-mailserver

georglauterbach · 2021-08-30T09:23:34Z

Description

This PR introduces GitHub forms and slightly alters the debug output for better visibility.

The debug output changed in so far as now a self-written function prints the environment in a useful way, and we do not use printenv anymore, because I think printenv clutters the whole log with information no one really needs. I did this because with the new form, we encourage people to use DMS_DEBUG=1 more, so I figured prettier log output / a non-cluttered log to begin with would be nice.

See this maintainers discussion

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (README.md or the documentation under docs/)
If necessary I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

georglauterbach · 2021-08-30T09:35:29Z

I cancelled the first ~~two~~ three workflows manually to not waste CPU time :)

Co-authored-by: William Desportes <[email protected]>

wernerfred · 2021-08-30T10:11:02Z

I will review carefully later today

…cker-mailserver into issue-forms

wernerfred

Thanks for this inital block of work. All in all this seems fine. But imho the wording is a bit to "agressive". I know that we have to deal a lot with people who don't use the templates or don't provide enough information but this form is here to solve this problem :)

As we do not want to kind of "scare" a few people from filing issue reports i vote for a friendlier wording here and there.

Co-authored-by: Frederic Werner <[email protected]>

10 days no response, requests were all addressed.

polarathene · 2021-09-09T22:47:41Z

No rush to merge this right? I have dismissed @wernerfred stale review, but I think we can leave this open over the weekend in case he still wants to chime in. If no other activity merge from Monday?

wernerfred

Sorry for not responding for a week now but i needed some time offline 🏞️

I looked at the rendering of the form and feel like that the <= syntax is not looking nice imho. I proposed a written variant but feel free to change the wording.

Thanks @polarathene for thinking of me and giving me time to throw in my two cents once again. 🚀

Feel free to merge if you disagree with my changes.

georglauterbach · 2021-09-10T08:26:56Z

Aright. I incorporated @wernerfred's feedback and added a feedback text area field to the forms for users to tell us their impressions too. I hope that all is well now :) Please leave your reviews (for the last time I hope) again :D

wernerfred

Nice idea with the feedback section 👍🏻

chore(issue forms): introduce issue forms and update debug output

0f4ae4e

georglauterbach added area/issue meta/needs triage This issue / PR needs checks and verification from maintainers kind/new feature A new feature is requested in this issue or implemeted with this PR priority/low labels Aug 30, 2021

georglauterbach added this to the v10.2.0 milestone Aug 30, 2021

georglauterbach requested review from a team August 30, 2021 09:23

georglauterbach self-assigned this Aug 30, 2021

update links to our code of conduct

f59acba

williamdes reviewed Aug 30, 2021

View reviewed changes

Comment thread .github/ISSUE_TEMPLATE/bug_report_form.yml Outdated

williamdes previously approved these changes Aug 30, 2021

View reviewed changes

added double-check mechanism

5ea0f29

georglauterbach dismissed williamdes’s stale review via 5ea0f29 August 30, 2021 09:34

Update .github/ISSUE_TEMPLATE/bug_report_form.yml

70e16fa

Co-authored-by: William Desportes <[email protected]>

casperklein reviewed Aug 30, 2021

View reviewed changes

Comment thread target/scripts/helper-functions.sh Outdated

Comment thread target/scripts/start-mailserver.sh Outdated

georglauterbach added 2 commits August 30, 2021 13:31

misc: alter start script and adjust form

de84818

I should adhere to my own style guidelines :D

a93cd33

williamdes reviewed Aug 30, 2021

View reviewed changes

Comment thread .github/ISSUE_TEMPLATE/bug_report_form.yml Outdated

add CPU core count and misc smaller changes

c7321bf

georglauterbach added the pr/needs review label Aug 30, 2021

Merge branch 'issue-forms' of https://github.com/docker-mailserver/do…

e556f64

…cker-mailserver into issue-forms

williamdes previously approved these changes Aug 30, 2021

View reviewed changes

wernerfred previously requested changes Aug 30, 2021

View reviewed changes

Update .github/ISSUE_TEMPLATE/bug_report_form.yml

0b0feb8

Co-authored-by: Frederic Werner <[email protected]>

georglauterbach dismissed williamdes’s stale review via 0b0feb8 August 30, 2021 20:42

georglauterbach added 2 commits August 30, 2021 23:38

adjusted template according to @wernerfred's suggestions

ba9ea5a

added experience field

69fca44

georglauterbach requested a review from wernerfred September 5, 2021 14:18

williamdes previously approved these changes Sep 5, 2021

View reviewed changes

georglauterbach removed the meta/needs triage This issue / PR needs checks and verification from maintainers label Sep 6, 2021

Merge branch 'master' into issue-forms

ef8c308

polarathene mentioned this pull request Sep 9, 2021

Skip non-deterministic tests until they've been debugged #2177

Merged

7 tasks

casperklein previously approved these changes Sep 9, 2021

View reviewed changes

georglauterbach requested review from wernerfred and removed request for wernerfred September 9, 2021 16:38

wernerfred previously approved these changes Sep 10, 2021

View reviewed changes

Comment thread .github/ISSUE_TEMPLATE/bug_report.yml Outdated

Comment thread .github/ISSUE_TEMPLATE/bug_report.yml Outdated

Comment thread .github/ISSUE_TEMPLATE/bug_report.yml Outdated

incorporate @wernerfred's changes and add feedback field

a5b6018

georglauterbach dismissed stale reviews from wernerfred, casperklein, williamdes, and polarathene via a5b6018 September 10, 2021 08:25

georglauterbach requested review from casperklein, polarathene, wernerfred and williamdes September 10, 2021 08:25

wernerfred previously approved these changes Sep 10, 2021

View reviewed changes

pronoun added

441f88f

casperklein dismissed wernerfred’s stale review via 441f88f September 10, 2021 14:44

casperklein approved these changes Sep 10, 2021

View reviewed changes

wernerfred approved these changes Sep 10, 2021

View reviewed changes

polarathene approved these changes Sep 10, 2021

View reviewed changes

polarathene merged commit 061ecf6 into master Sep 10, 2021

polarathene deleted the issue-forms branch September 10, 2021 22:49

williamdes removed their request for review November 26, 2021 15:52

Uh oh!

Conversation

georglauterbach commented Aug 30, 2021

Description

Type of change

Checklist:

Uh oh!

Uh oh!

georglauterbach commented Aug 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wernerfred commented Aug 30, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wernerfred left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

polarathene commented Sep 9, 2021

Uh oh!

wernerfred left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

georglauterbach commented Sep 10, 2021

Uh oh!

wernerfred left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

georglauterbach commented Aug 30, 2021 •

edited

Loading