Skip to content

switch to SHA512#210

Merged
tomav merged 2 commits intodocker-mailserver:masterfrom
Crafter6432:SHA512
Jun 14, 2016
Merged

switch to SHA512#210
tomav merged 2 commits intodocker-mailserver:masterfrom
Crafter6432:SHA512

Conversation

@Crafter6432
Copy link
Copy Markdown

@Crafter6432 Crafter6432 commented Jun 14, 2016

I removed test/auth/smtp-auth-cram-md5.txt because I don't think that CRAM-MD5-AUTH will work anymore, if we don't have a MD5 hash to compare against.

@Crafter6432
Copy link
Copy Markdown
Author

Crafter6432 commented Jun 14, 2016 •
edited
Loading

Any ideas how to fix this test ?

not ok 30 checking accounts: generated 'postfix-accounts.cf' matches template
# (in test file test/tests.bats, line 185)
#   `[ "$status" -eq 0 ]' failed

@tomav
Copy link
Copy Markdown
Contributor

tomav commented Jun 14, 2016

Yes, the test is diff test/config/example.postfix-accounts.cf test/config/postfix-accounts.cf
So you have to update test/config/example.postfix-accounts.cf as reference with SHA512 passwords.
Default clear password should be mypassword.

@tomav tomav mentioned this pull request Jun 14, 2016
Closed
@tomav tomav added the wip label Jun 14, 2016
@Crafter6432
Copy link
Copy Markdown
Author

Crafter6432 commented Jun 14, 2016

SHA512-CRYPT is salting the passwords, which means the hash is always different and thus not comparable.

@tomav tomav merged commit 0df999b into docker-mailserver:master Jun 14, 2016
@tomav
Copy link
Copy Markdown
Contributor

tomav commented Jun 14, 2016

Thank you. I update the Wiki.

RichardFevrier pushed a commit to RichardFevrier/docker-mailserver that referenced this pull request Aug 26, 2019
@tomav
Merge pull request docker-mailserver#210 from Crafter6432/SHA512
c4f13b4 
switch to SHA512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Crafter6432 @tomav