Skip to content

Update bats to latest stable version (1.4.1)#2095

Merged
casperklein merged 1 commit intodocker-mailserver:masterfrom
NorseGaud:update-bats
Jul 25, 2021
Merged

Update bats to latest stable version (1.4.1)#2095
casperklein merged 1 commit intodocker-mailserver:masterfrom
NorseGaud:update-bats

Conversation

@NorseGaud
Copy link
Copy Markdown
Member

@NorseGaud NorseGaud commented Jul 22, 2021 •
edited
Loading

Description

Updating bats to 1.4.0 (should be released in a few days); testing with 1.3.0 now. We currently use 1.2.1.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach requested a review from a team July 22, 2021 11:58
@georglauterbach georglauterbach added area/ci area/scripts kind/improvement Improve an existing feature, configuration file or the documentation meta/wip priority/medium labels Jul 22, 2021
@georglauterbach georglauterbach added this to the v10.1.0 milestone Jul 22, 2021
@wernerfred
Copy link
Copy Markdown
Member

wernerfred commented Jul 22, 2021

I'd also like to add some more advanced how-to bats notes in the docs as part of this PR, but we'll see.

+1 on that. Would really appreciate it 🚀

@NorseGaud NorseGaud changed the title Update bats to latest stable version Update bats to latest stable version (1.4.1) Jul 24, 2021
@NorseGaud
Copy link
Copy Markdown
Member Author

NorseGaud commented Jul 24, 2021

@wernerfred, sorry but I'm going to postpone the adding of the bats docs until after bats-core/bats-core#467 and 1.5.0 is released. This PR is ready to roll :)

@NorseGaud NorseGaud marked this pull request as ready for review July 24, 2021 22:03
wernerfred
wernerfred approved these changes Jul 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@wernerfred wernerfred left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as i cannot review the submodule 😄
Tests are passing

@casperklein casperklein merged commit 0e40f73 into docker-mailserver:master Jul 25, 2021
@wernerfred wernerfred modified the milestones: v10.1.0, v10.0.1 Jul 25, 2021
@NorseGaud NorseGaud mentioned this pull request Aug 2, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casperklein casperklein casperklein approved these changes

@wernerfred wernerfred wernerfred approved these changes

Assignees

@NorseGaud NorseGaud

Labels

area/ci area/scripts kind/improvement Improve an existing feature, configuration file or the documentation priority/medium

Projects

None yet

Milestone

v10.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@NorseGaud @wernerfred @casperklein @georglauterbach