add dovecot-fts-xapian by eleith · Pull Request #2064 · docker-mailserver/docker-mailserver

eleith · 2021-07-03T04:30:28Z

Description

this PR updates Docker to install dovecot-fts-xapian.

unfortunately, that package is only available on buster-backports so either Docker needs to be updated to pull from backports or the build can use bullseye-slim as the base image (which is nearing stable release in July 2021).

currently, this PR introduces bullseye-slim which is a rather large change.

I imagine this project will eventually adopt bullseye given its long testing cycle and relative stability. If so, this PR can be merged with that branch.

With that said, I would be happy to use buster-backports as well and i have a working branch, if desired. That approach merely requires updating Docker to add to apt a new source pointing to buster backports before installing dovecot and other software.

Lastly, this PR also updates relevant docs with instructions on how to enable fts-xapian
and what considerations to take into when deciding to turn on FTS and choose between xapian and solr.

Fixes #2061

Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation (README.md or the documentation under docs/)

update Docker to build from debian bullseye slim, as it contains packages for fts-xapian. update Docker to install dovecot-fts-xapian. update docs with instructions on how to enable fts-xapian or fts-solr and what considerations to take into when deciding.

wernerfred

Let's See what breaks with the new Base Image. I Started the ci Run.

I really appreciate that you included documentation in your PR. Was about to ask what this Plugin does but Docs explain it very Well

casperklein · 2021-07-03T09:59:00Z

Until Debian 11 is officially released, we should stick with the current version. The backport repo addition can then easily be removed once v11 is out.

casperklein · 2021-07-03T12:54:21Z

It seems, that our tests doesn't like bullseye yet 😋

eleith · 2021-07-03T16:12:30Z

addressed documentation feedback and used buster/backports approach instead. thanks everyone.

…t in a forced push)

eleith · 2021-07-03T18:04:21Z

"restored" proposal for backports from 5b462a2

wernerfred

LGTM 👍🏻

One could add admonition syntax to some sentences in the docs to highlight them but this is only a stylistic change.

Thanks for your contribution

casperklein · 2021-07-05T10:24:33Z

@eleith Great first contribution, thank you.

github-actions · 2021-07-05T10:25:43Z

Documentation preview for this PR is ready! 🎉

Built with commit: b1c16d5

wernerfred · 2021-07-05T10:27:10Z

Why tf did the merge went through with one test action still running. Need to investiagate 👀

casperklein · 2021-07-05T11:12:19Z

I had to update this branch (because of #2067 #2068): b1c16d5

Maybe that's related. TBH, in that case I am not mad about passing the tests, as the CI changes are not related to the image itself.

georglauterbach · 2021-07-06T07:23:22Z

@all-contributors please add @eleith for infrastructure

allcontributors · 2021-07-06T07:23:31Z

@georglauterbach

I've put up a pull request to add @eleith! 🎉

add dovecot-fts-xapian

706552f

update Docker to build from debian bullseye slim, as it contains packages for fts-xapian. update Docker to install dovecot-fts-xapian. update docs with instructions on how to enable fts-xapian or fts-solr and what considerations to take into when deciding.

wernerfred reviewed Jul 3, 2021

View reviewed changes