Install dbconfig-no-thanks package#2059
Merged
georglauterbach merged 1 commit intodocker-mailserver:masterfrom Jun 27, 2021
Merged
Install dbconfig-no-thanks package#2059georglauterbach merged 1 commit intodocker-mailserver:masterfrom
georglauterbach merged 1 commit intodocker-mailserver:masterfrom
Conversation
Debian opendmarc package has a dependency on dbconfig-mysql, which it will pull, together with its dependencies, during image build. Explicitly listing an alternative dbconfig-no-thanks package prevents installation of unnecessary packages and reduces the image size.
Member
|
50MB Image size reduction? Nice! Thank you for submitting this PR, very welcome! |
georglauterbach
approved these changes
Jun 27, 2021
polarathene
approved these changes
Jun 27, 2021
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
opendmarcpackage in Debian Buster includes an SQL schema to automatically create a MySQL database on installation. To do this, it has a dependency ondbconfig-mysqlpackage which is installed during the build. However, sincedocker-mailserverdoes not actually have a MySQL server running, this results in the following errors during the build process:It is not critical because the errors are ignored, but they can be fixed completely by explicitly installing the alternative
dbconfig-no-thankspackage.As far as I can tell,
opendmarcis not configured to use the database in anyway, so this change does not remove any functionality. But this way, sincedbconfig-mysqldoes not pull its dependencies (mariadb-client-10.3,mariadb-client-core-10.3,mariadb-common,mysql-common), the resulting image is a little bit smaller:Type of change
Checklist:
docs/)