Skip to content

reworked mail_crypt guide to make things way more simple and prepare …#2043

Merged
casperklein merged 7 commits intodocker-mailserver:masterfrom
NorseGaud:mail-crypt-doc-improvements
Jun 19, 2021
Merged

reworked mail_crypt guide to make things way more simple and prepare …#2043
casperklein merged 7 commits intodocker-mailserver:masterfrom
NorseGaud:mail-crypt-doc-improvements

Conversation

@NorseGaud
Copy link
Copy Markdown
Member

…for user folder encryption

Description

Preparing for per folder/user encryption guide per #1904 discussion by cleaning up and simplifying the mail_crypt guide. Also, not enabling mail_crypt globally doesn't allow doveadm mailbox cryptokey to work: http://dovecot.2317879.n4.nabble.com/doveadm-mailbox-cryptokey-not-found-td58533.html

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

wernerfred
wernerfred previously approved these changes Jun 18, 2021
Copy link
Copy Markdown
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georglauterbach georglauterbach added area/documentation kind/improvement Improve an existing feature, configuration file or the documentation priority/low service/dovecot labels Jun 18, 2021
@georglauterbach georglauterbach added this to the v10.0.1 milestone Jun 18, 2021
Comment thread docs/content/config/security/mail_crypt.md Outdated
Comment thread docs/content/config/security/mail_crypt.md Outdated
Comment thread docs/content/config/security/mail_crypt.md Outdated
Comment thread docs/content/config/security/mail_crypt.md Outdated
Comment thread docs/content/config/security/mail_crypt.md
@NorseGaud NorseGaud dismissed stale reviews from georglauterbach and wernerfred via 7f8f98b June 18, 2021 12:21
wernerfred
wernerfred previously approved these changes Jun 18, 2021
Comment thread docs/content/config/security/mail_crypt.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: 0b8ee4d

@casperklein casperklein merged commit 9c5d6ad into docker-mailserver:master Jun 19, 2021
@wernerfred
Copy link
Copy Markdown
Member

@all-contributors add @NorseGaud for documentation

@allcontributors
Copy link
Copy Markdown
Contributor

@wernerfred

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected string in JSON at position 396

@wernerfred wernerfred mentioned this pull request Jul 8, 2021
11 tasks
@wernerfred
Copy link
Copy Markdown
Member

@all-contributors add @NorseGaud for documentation

@allcontributors
Copy link
Copy Markdown
Contributor

@wernerfred

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected string in JSON at position 395

@wernerfred wernerfred mentioned this pull request Jul 8, 2021
7 tasks
@wernerfred
Copy link
Copy Markdown
Member

@all-contributors add @NorseGaud for documentation

@allcontributors
Copy link
Copy Markdown
Contributor

@wernerfred

I've put up a pull request to add @NorseGaud! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation kind/improvement Improve an existing feature, configuration file or the documentation priority/low service/dovecot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants