Skip to content

chore(ci): Linting Improved#2000

Merged
georglauterbach merged 9 commits intomasterfrom
update-linting
Jun 1, 2021
Merged

chore(ci): Linting Improved#2000
georglauterbach merged 9 commits intomasterfrom
update-linting

Conversation

@georglauterbach
Copy link
Copy Markdown
Member

@georglauterbach georglauterbach commented May 24, 2021

Description

Improves and updates the linting procedures.

  1. Bumped linter versions to their latest release as of today.
  2. Streamlined test/linting/lint.sh
  3. Added new configuration file for ECLint
  4. Had to update start-mailserver and setup-stack.sh as ShellCheck was complaining with v0.7.2. So I revised SPAMASSASIN_SPAM_TO_INBOX_SET for the better and removed the ugly sub-shell usage which was totally unnecessary.

Fixes #1997

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

PS: I got the PR marked with #2000 🎉

@georglauterbach georglauterbach added area/ci pr/needs review priority/low area/scripts kind/improvement Improve an existing feature, configuration file or the documentation labels May 24, 2021
@georglauterbach georglauterbach added this to the v10.0.1 milestone May 24, 2021
@georglauterbach georglauterbach self-assigned this May 24, 2021
@georglauterbach
Copy link
Copy Markdown
Member Author

Note: I stopped all but the latest CI runs on purpose :)

@NorseGaud
Copy link
Copy Markdown
Member

Linking the PRs for a paper-trail: #2001 includes all of these changes too

@wernerfred wernerfred added the meta/feature freeze On hold due to upcoming release process label May 24, 2021
@georglauterbach georglauterbach changed the title chore(ci): Liniting Improved chore(ci): Linting Improved May 24, 2021
@georglauterbach georglauterbach removed the meta/feature freeze On hold due to upcoming release process label Jun 1, 2021
@georglauterbach georglauterbach merged commit abdf681 into master Jun 1, 2021
@georglauterbach georglauterbach deleted the update-linting branch June 1, 2021 16:12
@wernerfred
Copy link
Copy Markdown
Member

@all-contributors add @georglauterbach for maintenance

@allcontributors
Copy link
Copy Markdown
Contributor

@wernerfred

I've put up a pull request to add @georglauterbach! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci area/scripts kind/improvement Improve an existing feature, configuration file or the documentation priority/low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local lint results are different from CI

4 participants