chore(ci): Linting Improved#2000
Merged
georglauterbach merged 9 commits intomasterfrom Jun 1, 2021
Merged
Conversation
Member
Author
|
Note: I stopped all but the latest CI runs on purpose :) |
Member
|
Linking the PRs for a paper-trail: #2001 includes all of these changes too |
11 tasks
polarathene
approved these changes
May 31, 2021
Member
|
@all-contributors add @georglauterbach for maintenance |
Contributor
|
I've put up a pull request to add @georglauterbach! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves and updates the linting procedures.
test/linting/lint.shstart-mailserverandsetup-stack.shas ShellCheck was complaining with v0.7.2. So I revisedSPAMASSASIN_SPAM_TO_INBOX_SETfor the better and removed the ugly sub-shell usage which was totally unnecessary.Fixes #1997
Type of change
Checklist:
docs/)PS: I got the PR marked with #2000 🎉