Skip to content

chore: add recreate option for comment of doc preview#1992

Merged
wernerfred merged 1 commit intomasterfrom
netlify-preview
May 20, 2021
Merged

chore: add recreate option for comment of doc preview#1992
wernerfred merged 1 commit intomasterfrom
netlify-preview

Conversation

@wernerfred
Copy link
Copy Markdown
Member

@wernerfred wernerfred commented May 20, 2021 •
edited
Loading

Description

add recreate option for comment of doc preview. See #1921 (comment)

Ref: https://github.com/marocchino/sticky-pull-request-comment#inputs

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@wernerfred wernerfred added area/ci pr/needs review kind/improvement Improve an existing feature, configuration file or the documentation area/documentation labels May 20, 2021
@wernerfred wernerfred added this to the v10.0.0 milestone May 20, 2021
@wernerfred wernerfred requested a review from polarathene May 20, 2021 18:13
@wernerfred wernerfred enabled auto-merge (squash) May 20, 2021 18:14
@wernerfred wernerfred mentioned this pull request May 20, 2021
Merged
8 tasks
@wernerfred wernerfred merged commit bb0c30f into master May 20, 2021
@wernerfred wernerfred deleted the netlify-preview branch May 20, 2021 23:24
@polarathene
Copy link
Copy Markdown
Member

polarathene commented May 21, 2021

I think the reason I preferred edit comment approach was to reduce e-mail notifications from CI adding new comments.

The long discussion threads on some PRs is a good reason to want to recreate comments, although one of the first comments would be the deploy preview comment so it should always be visible at the top anyway?

This feature works fine for now and it is a bit nicer contextually to have the deploy preview comment show after changes are made I guess 😅

@wernerfred
Copy link
Copy Markdown
Member Author

wernerfred commented May 21, 2021

This feature works fine for now and it is a bit nicer contextually to have the deploy preview comment show after changes are made I guess 😅

That's my point but this is also valid:

although one of the first comments would be the deploy preview comment so it should always be visible at the top anyway?

We will see how it behaves on different PRs and if we need to adapt it once again in future ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

Assignees

@polarathene polarathene

@wernerfred wernerfred

Labels

area/ci area/documentation kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Milestone

v10.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@wernerfred @polarathene