Skip to content

Remove stable branch from CI and build edge on schedule#1975

Merged
georglauterbach merged 4 commits intomasterfrom
remove-stable-branch
May 17, 2021
Merged

Remove stable branch from CI and build edge on schedule#1975
georglauterbach merged 4 commits intomasterfrom
remove-stable-branch

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented May 16, 2021

Description

  1. The stable branch has been removed from the CI.
  2. The scheduled build has been adjusted: stable --> edge.

After this PR is merged, the stable branch can be deleted.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented May 16, 2021

Any suggestions?

@casperklein casperklein self-assigned this May 16, 2021
@casperklein casperklein added area/ci kind/improvement Improve an existing feature, configuration file or the documentation priority/low labels May 16, 2021
@casperklein casperklein marked this pull request as ready for review May 16, 2021 21:39
@casperklein casperklein requested a review from a team May 16, 2021 21:40
@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented May 16, 2021

I like it, LGTM, but I would wait for other maintainers to give their opninion before merging this (of course :D) 👍

wernerfred
wernerfred approved these changes May 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wernerfred wernerfred changed the title Remove stable branch from CI Remove stable branch from CI and build edge on schedule May 17, 2021
@georglauterbach georglauterbach merged commit c5049c6 into master May 17, 2021
@georglauterbach georglauterbach deleted the remove-stable-branch branch May 17, 2021 07:45
@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented May 17, 2021

I will keep the :stable tag on DockerHub for a few weeks to not throw over someone who uses this tag ATM. I may give a deprecation notice in the README on DockerHub.

@wernerfred wernerfred added this to the v10.0.0 milestone May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polarathene polarathene polarathene approved these changes

@wernerfred wernerfred wernerfred approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels

area/ci kind/improvement Improve an existing feature, configuration file or the documentation priority/low

Projects

None yet

Milestone

v10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@casperklein @georglauterbach @polarathene @wernerfred