Skip to content

Use buildx in test_merge_requests.yml#1972

Merged
casperklein merged 2 commits intomasterfrom
test_merge_request_buildx
May 16, 2021
Merged

Use buildx in test_merge_requests.yml#1972
casperklein merged 2 commits intomasterfrom
test_merge_request_buildx

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented May 15, 2021 •
edited by georglauterbach
Loading

Description

I tried to add buildx to test_merge_requests.yml.

Fixes bad PR #1970
Closes #1971 (added by @aendeavor)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein requested a review from wernerfred May 15, 2021 20:25
@casperklein casperklein mentioned this pull request May 15, 2021
Merged
8 tasks
@casperklein casperklein changed the title Update test_merge_requests.yml Use buildx in test_merge_requests.yml May 15, 2021
@casperklein casperklein added area/ci kind/improvement Improve an existing feature, configuration file or the documentation labels May 15, 2021
@casperklein casperklein self-assigned this May 15, 2021
@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented May 16, 2021 •
edited
Loading

Seems to work fine, I have no objections: LGTM 👍

@wernerfred What's your take?

PS: This seems to indicate that curl works fine even without the --insecure flag. #1971 could then be closed.

wernerfred
wernerfred previously approved these changes May 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the whole cache part is not necessary as the image (layers) differ for every architecture and we are only building once (compared to default_on_push where we have a local build during test and then a local build during push).
So caching will add only time but no benefit if i didn't overlook something.

Apart from the time aspect caching does not change functionality so this can be merged directly or caching can be excluded to optimize the workflow further.

@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented May 16, 2021

I just copy/pasted it from default_on_push.yml. The same came to my mind also, after providing this PR. But I wasn't sure, so I leaved it unchanged.

@casperklein casperklein dismissed stale reviews from wernerfred and georglauterbach via 55ae543 May 16, 2021 09:17
@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented May 16, 2021

I have removed the cache stuff.

@casperklein casperklein requested a review from wernerfred May 16, 2021 09:18
@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented May 16, 2021

GitHub behaves strangely ATM. The check does not start(?) At least I do not see it.

@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented May 16, 2021

I noticed the same in other repos. The tests are queued. GitHub seems a bit sluggish today.

@wernerfred
Copy link
Copy Markdown
Member

wernerfred commented May 16, 2021

Seems Like we have to wait until ghactions are operational again: https://www.githubstatus.com/

@casperklein casperklein merged commit 17d6565 into master May 16, 2021
@casperklein casperklein deleted the test_merge_request_buildx branch May 16, 2021 16:54
casperklein added a commit that referenced this pull request May 16, 2021
@casperklein
Fix bug intruduced in #1972
bb26ff1
@casperklein casperklein mentioned this pull request May 16, 2021
Merged
11 tasks
casperklein added a commit that referenced this pull request May 16, 2021
@casperklein
CI fix for #1972
d5bbcb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wernerfred wernerfred wernerfred approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels

area/ci area/tests kind/improvement Improve an existing feature, configuration file or the documentation priority/high

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@casperklein @georglauterbach @wernerfred