Skip to content

Add ARM platforms#1970

Merged
casperklein merged 1 commit intomasterfrom
casperklein-patch-1
May 15, 2021
Merged

Add ARM platforms#1970
casperklein merged 1 commit intomasterfrom
casperklein-patch-1

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented May 15, 2021 •
edited
Loading

Description

ARM platforms added to test action.

If we only test against amd64, later (multiarch) build & publish action can fail.

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein requested a review from a team May 15, 2021 11:06
@casperklein casperklein self-assigned this May 15, 2021
@casperklein casperklein added area/ci kind/improvement Improve an existing feature, configuration file or the documentation labels May 15, 2021
@georglauterbach
Copy link
Copy Markdown
Member

georglauterbach commented May 15, 2021

I would only test against arm64 to reduce time spent in testing. Otherwise, LGTM

@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented May 15, 2021

It's not guaranteed, that if the arm64 build succeed, arm/v7 will also succeed.

We should test against all platforms we build images for. The tests run in parallel, so I don't think there will be much time saved, when excluding arm/v7.

@wernerfred wernerfred mentioned this pull request May 15, 2021
Merged
8 tasks
@casperklein casperklein merged commit 23afce5 into master May 15, 2021
@casperklein casperklein deleted the casperklein-patch-1 branch May 15, 2021 18:36
@georglauterbach georglauterbach mentioned this pull request May 15, 2021
Merged
11 tasks
@casperklein casperklein mentioned this pull request May 15, 2021
Merged
11 tasks
@casperklein
Copy link
Copy Markdown
Member Author

casperklein commented May 16, 2021

@aendeavor In the end, you were right.

Building for amd64 platform alone takes about 2 minutes. However emulated (QEMU) arm builds are taking 18min. This adds ~16 minutes to the build process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wernerfred wernerfred wernerfred approved these changes

@georglauterbach georglauterbach georglauterbach approved these changes

Assignees

@casperklein casperklein

Labels

area/ci kind/improvement Improve an existing feature, configuration file or the documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@casperklein @georglauterbach @wernerfred